Skip to content

Update Omega to C++20#405

Draft
mwarusz wants to merge 5 commits into
E3SM-Project:developfrom
mwarusz:omega/cxx20
Draft

Update Omega to C++20#405
mwarusz wants to merge 5 commits into
E3SM-Project:developfrom
mwarusz:omega/cxx20

Conversation

@mwarusz

@mwarusz mwarusz commented May 12, 2026

Copy link
Copy Markdown
Member

This draft PR updates Omega C++ standard to C++20. E3SM is in the process to upgrading to Kokkos 5, which requires C++20. This PR has the necessary fixes on the Omega side.

Checklist

  • Linting
  • Building
    • CMake build does not produce any new warnings from changes in this PR
  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • The Polaris omega_pr test suite
        has passed, using the Polaris e3sm_submodules/Omega baseline
      • Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
      • Indicate "All tests passed" or document failing tests

@grnydawn grnydawn self-requested a review May 14, 2026 18:16

@grnydawn grnydawn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code visually, and it looks good to me. All tests are passed on Frontier(craygnu-mphipcc, craycray-mphipcc, and craygnu), PM-CPU(gnu), PM-GPU(gnugpu), and Chrysalis(gnu). Approved.

@grnydawn

Copy link
Copy Markdown

Due to replacing the spdlog submodule with a new version and location, the changes to the logging module in this PR conflict with those in the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants