Skip to content

Apply xstride updates from driver-mct to driver-moab#8501

Open
amametjanov wants to merge 2 commits into
masterfrom
azamat/driver-moab/add-excl-stride-init-lookahead
Open

Apply xstride updates from driver-mct to driver-moab#8501
amametjanov wants to merge 2 commits into
masterfrom
azamat/driver-moab/add-excl-stride-init-lookahead

Conversation

@amametjanov

Copy link
Copy Markdown
Member

Apply xstride updates from driver-mct to driver-moab.

[BFB]


Testing: WIP

@amametjanov amametjanov added Coupler Related to code in driver-mct or driver-moab or component connections to the coupler. BFB PR leaves answers BFB Performance labels Jun 18, 2026
@amametjanov amametjanov requested a review from Copilot June 18, 2026 22:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ports the “xstride / excl-stride” communicator-setup updates from the
driver-mct implementation into driver-moab, ensuring exclusive-task groups
are initialized early enough to be honored when creating component
communicators.

Changes:

  • Add early initialization of exclusive-stride MPI groups (via xcount +
    comp_exstride_init) prior to comp_comm_init calls.
  • Add helper subroutine comp_exstride_init to build/store excl-stride groups.
  • Update seq_comm_setcomm to exclude exclusive-task groups across all comm IDs
    (not just IDs created earlier).

Comment thread driver-moab/shr/seq_comm_mct.F90
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread driver-moab/shr/seq_comm_mct.F90
@rljacob rljacob self-assigned this Jun 19, 2026
@rljacob rljacob requested a review from wlin7 June 26, 2026 15:05
@rljacob

rljacob commented Jul 6, 2026

Copy link
Copy Markdown
Member

@wlin tested this and found it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BFB PR leaves answers BFB Coupler Related to code in driver-mct or driver-moab or component connections to the coupler. Performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants