Skip to content

eamxx: set fillval thresholds to match science/diags #8481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mahf708 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

eamxx: set fillval thresholds to match science/diags #8481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/eamxx/src/share/io/scorpio_output.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ class AtmosphereOutput
// How to combine multiple snapshots in the output: instant, Max, Min, Average
OutputAvgType m_avg_type;
Real m_avg_coeff_threshold =
0.5; // % of unfilled values required to not just assign value as FillValue
0.01; // % of unfilled values required to not just assign value as FillValue
Comment on lines 223 to +224

// Internal maps to the output fields, how the columns are distributed, the file dimensions and
// the global ids.
Expand Down
2 changes: 1 addition & 1 deletion components/eamxx/src/share/remap/horizontal_remapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ rescale_masked_fields (const Field& x, const Field& real_mask) const
const auto& layout = x.get_header().get_identifier().get_layout();
const int rank = layout.rank();
const int ncols = m_tgt_grid->get_num_local_dofs();
const Real mask_threshold = std::numeric_limits<Real>::epsilon(); // TODO: Should we not hardcode the threshold for simply masking out the column.
const Real mask_threshold = 0.25;

Pack fv_pack(fill_val);
auto& mask = x.get_valid_mask();
Expand Down
Loading