-
Notifications
You must be signed in to change notification settings - Fork 658
WIP net10.0 Update #15933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WIP net10.0 Update #15933
Conversation
} | ||
catch(Exception e) | ||
{ | ||
//log the error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where we can support some logging or alternative loading option for legacy packages
} | ||
byte[] imageBytes = rm.GetObject(icon.Name) as byte[]; | ||
string base64String = Convert.ToBase64String(imageBytes); | ||
return base64String; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change here is actually an optimization. Currently the exception for casting to Bitmap is caught outside of this function. Maybe we also do something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Dynamo repo to target net10.0, addressing runtime serialization changes and resolving ambiguous references in menu item code. Key changes include:
- Updating MenuItem type references to use System.Windows.Controls.MenuItem for clarity.
- Refactoring icon loading logic to use embedded resource byte[] with runtime deserialization.
- Upgrading build configurations and workflows from net8.0 to net10.0.
Reviewed Changes
Copilot reviewed 2289 out of 2289 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs | Updated MenuItem references for explicit namespace qualification. |
src/DynamoCoreWpf/Services/IconServices.cs | Modified icon loading to use MemoryStream and runtime deserialization. |
src/Config/CS_SDK.props | Updated target framework from net8.0 to net10.0. |
.github/workflows/issue_type_predicter.yml | Updated dotnet restore/cp commands for net10.0 builds. |
.github/workflows/dynamo_bin_diff.yml | Updated msbuild commands to target net10.0. |
} | ||
catch(Exception e) | ||
{ | ||
//log the error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider logging the exception details within the catch block instead of silently swallowing the error, to facilitate easier debugging in production.
//log the error | |
System.Diagnostics.Debug.WriteLine($"Error loading icon '{iconKey}': {e.Message}\n{e.StackTrace}"); |
Copilot uses AI. Check for mistakes.
Purpose
WIP. The purpose of this PR is to update the Dynamo Repo from net8.0 to net10.0. The changes include:
MenuItem
byte[]
format. Due to the runtime serialization, the individual images files are now included explicitly in the repo.Todo
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Byte[]
Reviewers
@zeusongit @sm6srw @aparajit-pratap
FYIs
@Amoursol @achintyabhat @jasonstratton