Skip to content

Fix many effects playing on the master bus #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zibetnu wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fix many effects playing on the master bus #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions project/assets/effects/WallParticles.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,4 @@ script = SubResource( 4 )
stream = SubResource( 5 )
volume_db = -6.433
autoplay = true
bus = "SFX"
9 changes: 9 additions & 0 deletions project/characters/drill/Shark.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,27 +41,36 @@ visible = false

[node name="SFX2" type="AudioStreamPlayer" parent="DeathSFXs" index="1"]
stream = ExtResource( 7 )
bus = "SFX"

[node name="SFX3" type="AudioStreamPlayer" parent="DeathSFXs" index="2"]
stream = ExtResource( 8 )
bus = "SFX"

[node name="SFX4" type="AudioStreamPlayer" parent="DeathSFXs" index="3"]
stream = ExtResource( 9 )
bus = "SFX"

[node name="SFX5" type="AudioStreamPlayer" parent="DeathSFXs" index="4"]
stream = ExtResource( 10 )
bus = "SFX"

[node name="SFX6" type="AudioStreamPlayer" parent="DeathSFXs" index="5"]
stream = ExtResource( 11 )
bus = "SFX"

[node name="SFX2" type="AudioStreamPlayer" parent="HitSFXs" index="1"]
stream = ExtResource( 13 )
bus = "SFX"

[node name="SFX3" type="AudioStreamPlayer" parent="HitSFXs" index="2"]
stream = ExtResource( 14 )
bus = "SFX"

[node name="SFX4" type="AudioStreamPlayer" parent="HitSFXs" index="3"]
stream = ExtResource( 15 )
bus = "SFX"

[node name="SFX5" type="AudioStreamPlayer" parent="HitSFXs" index="4"]
stream = ExtResource( 16 )
bus = "SFX"
8 changes: 8 additions & 0 deletions project/characters/jackie/Shark.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,27 +40,35 @@ stream = ExtResource( 2 )

[node name="SFX2" type="AudioStreamPlayer" parent="DeathSFXs" index="1"]
stream = ExtResource( 3 )
bus = "SFX"

[node name="SFX3" type="AudioStreamPlayer" parent="DeathSFXs" index="2"]
stream = ExtResource( 4 )
bus = "SFX"

[node name="SFX4" type="AudioStreamPlayer" parent="DeathSFXs" index="3"]
stream = ExtResource( 5 )
bus = "SFX"

[node name="SFX5" type="AudioStreamPlayer" parent="DeathSFXs" index="4"]
stream = ExtResource( 6 )
bus = "SFX"

[node name="SFX1" parent="HitSFXs" index="0"]
stream = ExtResource( 7 )

[node name="SFX2" type="AudioStreamPlayer" parent="HitSFXs" index="1"]
stream = ExtResource( 8 )
bus = "SFX"

[node name="SFX3" type="AudioStreamPlayer" parent="HitSFXs" index="2"]
stream = ExtResource( 9 )
bus = "SFX"

[node name="SFX4" type="AudioStreamPlayer" parent="HitSFXs" index="3"]
stream = ExtResource( 10 )
bus = "SFX"

[node name="SFX5" type="AudioStreamPlayer" parent="HitSFXs" index="4"]
stream = ExtResource( 11 )
bus = "SFX"
11 changes: 11 additions & 0 deletions project/characters/king/Shark.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,36 +51,47 @@ stream = ExtResource( 6 )

[node name="SFX2" type="AudioStreamPlayer" parent="DeathSFXs" index="1"]
stream = ExtResource( 7 )
bus = "SFX"

[node name="SFX3" type="AudioStreamPlayer" parent="DeathSFXs" index="2"]
stream = ExtResource( 8 )
bus = "SFX"

[node name="SFX4" type="AudioStreamPlayer" parent="DeathSFXs" index="3"]
stream = ExtResource( 9 )
bus = "SFX"

[node name="SFX1" parent="HitSFXs" index="0"]
stream = ExtResource( 10 )

[node name="SFX2" type="AudioStreamPlayer" parent="HitSFXs" index="1"]
stream = ExtResource( 11 )
bus = "SFX"

[node name="SFX3" type="AudioStreamPlayer" parent="HitSFXs" index="2"]
stream = ExtResource( 12 )
bus = "SFX"

[node name="SFX4" type="AudioStreamPlayer" parent="HitSFXs" index="3"]
stream = ExtResource( 13 )
bus = "SFX"

[node name="SFX5" type="AudioStreamPlayer" parent="HitSFXs" index="4"]
stream = ExtResource( 14 )
bus = "SFX"

[node name="SFX6" type="AudioStreamPlayer" parent="HitSFXs" index="5"]
stream = ExtResource( 15 )
bus = "SFX"

[node name="SFX7" type="AudioStreamPlayer" parent="HitSFXs" index="6"]
stream = ExtResource( 16 )
bus = "SFX"

[node name="SFX8" type="AudioStreamPlayer" parent="HitSFXs" index="7"]
stream = ExtResource( 17 )
bus = "SFX"

[node name="SFX9" type="AudioStreamPlayer" parent="HitSFXs" index="8"]
stream = ExtResource( 18 )
bus = "SFX"
11 changes: 11 additions & 0 deletions project/characters/outsider/Shark.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,36 +48,47 @@ stream = ExtResource( 5 )

[node name="SFX2" type="AudioStreamPlayer" parent="DeathSFXs" index="1"]
stream = ExtResource( 6 )
bus = "SFX"

[node name="SFX3" type="AudioStreamPlayer" parent="DeathSFXs" index="2"]
stream = ExtResource( 7 )
bus = "SFX"

[node name="SFX4" type="AudioStreamPlayer" parent="DeathSFXs" index="3"]
stream = ExtResource( 8 )
bus = "SFX"

[node name="SFX5" type="AudioStreamPlayer" parent="DeathSFXs" index="4"]
stream = ExtResource( 9 )
bus = "SFX"

[node name="SFX6" type="AudioStreamPlayer" parent="DeathSFXs" index="5"]
stream = ExtResource( 10 )
bus = "SFX"

[node name="SFX7" type="AudioStreamPlayer" parent="DeathSFXs" index="6"]
stream = ExtResource( 11 )
bus = "SFX"

[node name="SFX1" parent="HitSFXs" index="0"]
stream = ExtResource( 12 )

[node name="SFX2" type="AudioStreamPlayer" parent="HitSFXs" index="1"]
stream = ExtResource( 13 )
bus = "SFX"

[node name="SFX3" type="AudioStreamPlayer" parent="HitSFXs" index="2"]
stream = ExtResource( 14 )
bus = "SFX"

[node name="SFX4" type="AudioStreamPlayer" parent="HitSFXs" index="3"]
stream = ExtResource( 15 )
bus = "SFX"

[node name="SFX5" type="AudioStreamPlayer" parent="HitSFXs" index="4"]
stream = ExtResource( 16 )
bus = "SFX"

[node name="SFX6" type="AudioStreamPlayer" parent="HitSFXs" index="5"]
stream = ExtResource( 17 )
bus = "SFX"
1 change: 1 addition & 0 deletions project/gameplay/hud/countdown/Countdown.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,3 +188,4 @@ align = 1
[node name="SFX" type="AudioStreamPlayer" parent="."]
stream = ExtResource( 4 )
volume_db = -16.171
bus = "SFX"
1 change: 1 addition & 0 deletions project/gameplay/objects/obstacles/whirlpool/Whirlpool.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,4 @@ texture = ExtResource( 4 )

[node name="SFX" type="AudioStreamPlayer2D" parent="."]
autoplay = true
bus = "SFX"
5 changes: 5 additions & 0 deletions project/gameplay/player/Shark.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,19 +447,24 @@ position = Vector2( 0, -210 )

[node name="SFX1" type="AudioStreamPlayer" parent="DeathSFXs"]
stream = ExtResource( 5 )
bus = "SFX"

[node name="HitSFXs" type="Node" parent="."]

[node name="SFX1" type="AudioStreamPlayer" parent="HitSFXs"]
stream = ExtResource( 6 )
bus = "SFX"

[node name="ExplosionSFXs" type="Node" parent="."]

[node name="ExplosionSFX1" type="AudioStreamPlayer" parent="ExplosionSFXs"]
stream = ExtResource( 7 )
bus = "SFX"

[node name="ExplosionSFX2" type="AudioStreamPlayer" parent="ExplosionSFXs"]
stream = ExtResource( 8 )
bus = "SFX"

[node name="ExplosionSFX3" type="AudioStreamPlayer" parent="ExplosionSFXs"]
stream = ExtResource( 9 )
bus = "SFX"
1 change: 1 addition & 0 deletions project/gameplay/player/hook/Hook.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ shape = SubResource( 1 )
[node name="RetractSFX" type="AudioStreamPlayer" parent="."]
stream = SubResource( 2 )
volume_db = -6.433
bus = "SFX"

[connection signal="area_entered" from="HookArea" to="." method="_on_HookArea_area_entered"]
[connection signal="finished" from="RetractSFX" to="." method="_on_RetractSFX_finished"]
1 change: 1 addition & 0 deletions project/gameplay/race-mode/FinishLine.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ anims/float = SubResource( 1 )
[node name="SFX" type="AudioStreamPlayer" parent="."]
stream = ExtResource( 4 )
volume_db = -6.245
bus = "SFX"

[connection signal="area_entered" from="LineArea" to="." method="_on_LineArea_area_entered"]
[connection signal="hooked" from="PullableObjectBot" to="." method="_on_PullableObjectBot_hooked"]
Expand Down
4 changes: 4 additions & 0 deletions project/menus/character-select/CharacterSelect.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,18 +204,22 @@ anims/show = SubResource( 3 )
[node name="DenySFX" type="AudioStreamPlayer" parent="Sounds"]
stream = ExtResource( 17 )
volume_db = -6.058
bus = "SFX"

[node name="PressStartSFX" type="AudioStreamPlayer" parent="Sounds"]
stream = ExtResource( 18 )
volume_db = -5.361
bus = "SFX"

[node name="ArenaSFX" type="AudioStreamPlayer" parent="Sounds"]
stream = ExtResource( 19 )
volume_db = -5.362
bus = "SFX"

[node name="RaceSFX" type="AudioStreamPlayer" parent="Sounds"]
stream = ExtResource( 20 )
volume_db = -5.362
bus = "SFX"

[connection signal="completed" from="BackIndicator" to="." method="_on_BackIndicator_completed"]

Expand Down