fix(notification): support live notification variants - #485
Open
jacobo-doist wants to merge 2 commits into
Open
Conversation
doistbot
reviewed
Aug 19, 2026
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR updates the notification parsing to use the SDK 14.0.2 camelCase live-notification schema, adds a fromUser/fromUid fallback, and introduces API-boundary tests covering sender, project, task, invitation, deletion, and sorting paths.
No inline issues were flagged.
I also included a few optional follow-up notes in the details below.
Optional follow-up notes (2)
src/lib/api/notifications.test.ts:19: This hand-rolls the API mock setup that
setupApiMock()already provides.setupApiMock()(fromsrc/test-support/api-mock.ts) creates the mock API and wiresgetApi()to it, and CODEBASE.md documents it as the standard test pattern. Keep the hoistedvi.mock('./core.js', ...)but replace thecreateMockApi()import,mockGetApi, and themockApi = createMockApi(); mockGetApi.mockResolvedValue(mockApi)lines withmockApi = setupApiMock().src/lib/api/notifications.test.ts:63:
toEqualignores object keys whose value isundefined, sotask: undefined,invitationId: undefined, andinvitationSecret: undefinedin the expected objects assert nothing. Since this test is meant to pin the API-boundary shape, usetoStrictEqual(which checks the exact keys, including undefined-valued ones) or drop those no-op keys.
scottlovegrove
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@doist/todoist-sdkto 14.0.2 for its live-notification schema fixesfromUserwithoutfromUidTesting
npm run buildnpm testnpm run type-checknpm run checknpm run check:skill-syncnotification listsmoke test using the local build