Replace insecure MD5 hash with SHA-256 for PDF signature generation #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR replaces usage of the insecure md5 hashing algorithm with sha256 in pdfdoc.py. MD5 is known to be cryptographically broken and is vulnerable to collision and pre-image attacks. Replacing it with SHA-256 aligns the library with modern security practices, especially when generating PDF identifiers and document signatures.
Shivam-Singh-Dev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces usage of the insecure md5 hashing algorithm with sha256 in pdfdoc.py.
MD5 is known to be cryptographically broken and is vulnerable to collision and pre-image attacks. Replacing it with SHA-256 aligns the library with modern security practices, especially when generating PDF identifiers and document signatures.