ENG-1867 Import cross-app relations into Roam as tentative relations by maparent · Pull Request #1302 · DiscourseGraphs/discourse-graph

maparent · 2026-08-17T15:58:08Z

https://linear.app/discourse-graphs/issue/ENG-1867/import-cross-app-relations-into-roam-as-tentative-relations

Code walkthrough:
https://www.loom.com/share/e3cfe2ce63a34382a2b23200cb9e0b1e

Note: Since the code walkthrough I removed the RidToId in the discovery results.
Also added the correction to getDiscourseRelations, and code to delete an incorrect imported relation.

Simple demo:
https://www.loom.com/share/a0dd5ca98a194536a6d4350ec96b8bcb

Demo with type creation:
https://www.loom.com/share/bc8336651d7243f1b6f809ee6e886d9f

Quick note on templates
https://www.loom.com/share/5bfd0fffc27446af9d5d88383c7e276a

linear-code · 2026-08-17T15:58:11Z

ENG-1867

supabase · 2026-08-17T15:58:14Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

vercel · 2026-08-17T16:20:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
discourse-graph	Skipped		Aug 27, 2026 11:48pm

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 7 additional findings.

maparent · 2026-08-22T17:29:24Z

Ok. Addressed most issues.
Some codex comments lost their anchor after the rebase, and before I processed them; so they are lost and might still apply, I would ask for another codex review. But all active comments were addressed.

mdroidian · 2026-08-24T07:15:48Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0dcb0f2bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mdroidian · 2026-08-24T22:55:39Z

+  let templateTree: RoamBasicNode[] | undefined;
+  if (template !== undefined) {
+    const tree = getBasicTreeByParentUid(pageUid);
+    const templateUid = tree[3].uid;


tree[3] assumes Template is always the 4th child. That’s true for the tree you just built, but it isn’t a stable way to find the block.

If someone later adds, removes, or reorders a setting above Template, this still compiles and then writes markdown into the wrong parent. Easy to miss because the 3 is disconnected from the "Template" key.

Elsewhere we look these up by name with getSubTree. Same thing here:
const templateUid = getSubTree({ tree, key: "Template" }).uid;

mdroidian · 2026-08-24T23:01:26Z

+  label: string;
+  shortcut?: string;
+  format?: string;
+  template?: string;


It looks like you are expecting a Markdown string here? Normally, in Roam, templates are RoamBasicNode[]. So this is going against the expected pattern. Let's explicitly called out as a comment on ln 1109, or a custom type, or even JSONDoc above the function.

It may be true that CrossApp* will generally expect Markdown, but this is currently in accessors.ts, so the context matters.

Actually broadening the type.

maparent · 2026-08-26T14:13:35Z

Made a few changes. I choose to allow relations with no condition vs creating an empty condition. I also broadened the input type.

mdroidian · 2026-08-27T04:30:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e6a60d7cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-27T04:33:35Z

+        sourceUid,
+        destinationUid,
+        relationBlockUid,
+        tentative: true,


Exclude tentative relations from accepted-relation queries

When stored relations are enabled, this imported relation is immediately treated as an accepted fact: registerDiscourseDatalogTranslators matches every reified block using only sourceUid, destinationUid, and hasSchema, and no Roam consumer filters the newly added tentative property. Consequently, merely importing shared nodes can change query, context, and canvas results before the user accepts the relation; exclude tentative records from normal relation paths until confirmation.

Useful? React with 👍 / 👎.

This is valid, but I think it's a new scope.

vercel Bot temporarily deployed to Preview August 17, 2026 16:20 Inactive

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from 452cc49 to 1928997 Compare August 17, 2026 22:37

vercel Bot temporarily deployed to Preview August 17, 2026 22:37 Inactive

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from 1928997 to 70f63a7 Compare August 19, 2026 13:37

vercel Bot deployed to Preview August 19, 2026 13:40 View deployment

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from 70f63a7 to 5ce9525 Compare August 19, 2026 14:19

vercel Bot temporarily deployed to Preview August 19, 2026 14:19 Inactive

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from 5ce9525 to 69aedbc Compare August 19, 2026 14:32

vercel Bot temporarily deployed to Preview August 19, 2026 14:32 Inactive

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from 69aedbc to 9036ffd Compare August 19, 2026 14:56

vercel Bot temporarily deployed to Preview August 19, 2026 14:56 Inactive

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from 9036ffd to f4ef064 Compare August 19, 2026 16:33

vercel Bot temporarily deployed to Preview August 19, 2026 16:33 Inactive

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from f4ef064 to c3e095b Compare August 20, 2026 01:09

vercel Bot temporarily deployed to Preview August 20, 2026 01:09 Inactive

maparent marked this pull request as ready for review August 20, 2026 01:13

graphite-app Bot reviewed Aug 20, 2026

View reviewed changes

Comment thread apps/roam/src/utils/importSharedRelations.ts Outdated

devin-ai-integration Bot reviewed Aug 20, 2026

View reviewed changes

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from c3e095b to b062e59 Compare August 20, 2026 01:22

vercel Bot temporarily deployed to Preview August 20, 2026 01:23 Inactive

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from b0d1031 to a360ea2 Compare August 22, 2026 16:03

vercel Bot temporarily deployed to Preview August 22, 2026 16:03 Inactive

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from a360ea2 to 5f45a0d Compare August 22, 2026 16:10

vercel Bot temporarily deployed to Preview August 22, 2026 16:10 Inactive

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from 5f45a0d to 6699f70 Compare August 22, 2026 16:29

vercel Bot temporarily deployed to Preview August 22, 2026 16:29 Inactive

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from 6699f70 to 84c96a5 Compare August 22, 2026 17:24

vercel Bot temporarily deployed to Preview August 22, 2026 17:24 Inactive

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from 84c96a5 to d0dcb0f Compare August 22, 2026 17:25

vercel Bot temporarily deployed to Preview August 22, 2026 17:26 Inactive

maparent requested a review from mdroidian August 22, 2026 17:29

chatgpt-codex-connector Bot reviewed Aug 24, 2026

View reviewed changes

Comment thread apps/roam/src/utils/importSharedRelations.ts

Comment thread apps/roam/src/utils/importSharedRelations.ts

Comment thread apps/roam/src/utils/createRelationSchema.ts

mdroidian requested changes Aug 24, 2026

View reviewed changes

maparent force-pushed the eng-1867-Import-cross-app–relations-in-roam-as-tentative branch from d0dcb0f to 2e6a60d Compare August 26, 2026 14:08

maparent requested a review from mdroidian August 26, 2026 14:13

chatgpt-codex-connector Bot reviewed Aug 27, 2026

View reviewed changes

maparent added 9 commits August 27, 2026 17:50

ENG-1867 function to import relations and schemas after discover

80f9e30

actually import the relations

aa6a05c

tentative flag

53ef2f5

Correction to getDiscourseRelations: allow triple-less relations

c9f0085

allow rel to local target

806e1ab

add new relation to global settings

1f1770a

Repair tests

72e98a0

respond to comments

fc173c0

add current space to spaceMap

668346f

mdroidian approved these changes Aug 28, 2026

View reviewed changes

Uh oh!

Hidden character warning

Conversation

maparent commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code Bot commented Aug 17, 2026

Uh oh!

supabase Bot commented Aug 17, 2026

Uh oh!

vercel Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

maparent commented Aug 22, 2026

Uh oh!

mdroidian commented Aug 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdroidian Aug 24, 2026

Choose a reason for hiding this comment

Uh oh!

mdroidian Aug 24, 2026

Choose a reason for hiding this comment

Uh oh!

maparent Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maparent commented Aug 26, 2026

Uh oh!

mdroidian commented Aug 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

maparent Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maparent commented Aug 17, 2026 •

edited

Loading

vercel Bot commented Aug 17, 2026 •

edited

Loading