Fix/1286 transition rules unified - #1494
Open
Ayomide-codex wants to merge 2 commits into
Open
Conversation
…tusAction gap (Disciplr-Org#1286) Add MissingVerifierAuditActionError typed exception class (mirroring InvalidVerifierStatusTransitionError) so statusAction-driven audit lookup failures produce a catchable, distinguishable error instead of a generic Error. Catch it in PATCH /:userId, transitionStatus helper, and reinstate handler to return 500 with the specific error message.
|
@Ayomide-codex Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the generic
Errorthrown during verifier profile audit action lookup with a dedicated, typed exception. This improves error handling by making internal inconsistencies between verifier status transition validation and audit action mapping explicit, allowing callers to distinguish this failure from unexpected server errors.Changes Made
Errorthrown inupdateVerifierProfilewith the new exception.Files Updated
src/services/verifiers.tssrc/routes/adminVerifiers.ts(if required for explicit handling)Testing
npm testsuccessfully with project coverage meeting the required threshold.Benefits
Errorfor a known application failure mode.Documentation
Checklist
Errorreplacedcloses #1286