Skip to content

[Quality] Persist notification read state across sessions safely #1133

Description

@1nonlypiece

Problem

Notifications can become inconsistent across tabs or disappear on reload, making verifier and vault activity easy to miss.

This issue requires a meaningful production implementation. Typo-only, documentation-only, formatting-only, dependency-only, or cosmetic changes do not satisfy the scope.

Objective

Add a versioned notification persistence and synchronization strategy with bounded storage.

Scope

Define IDs, deduplication, unread semantics, cross-tab updates, expiry, and migration for older stored data.

Acceptance criteria

  • The same notification is not duplicated across refresh or tabs.
  • Read/unread changes converge across open tabs.
  • Corrupt or oversized storage fails closed without breaking the app.
  • Tests cover migration, expiry, deduplication, cross-tab events, and reset.
  • Existing CI/CD checks remain green.
  • The PR explains the design, tradeoffs, test evidence, and any remaining limitations.
  • The PR references this issue with Closes #{issue-number} or Fixes #{issue-number}.

Implementation notes

Implement only the stated behavior; keep unrelated refactors out of the PR.

Non-goals

  • Do not remove tests merely to make CI pass.
  • Do not introduce secrets, private keys, credentials, or mainnet-only values.
  • Do not change unrelated APIs, UI surfaces, contract behavior, or deployment configuration.

Contributor application

Before starting, comment with relevant experience, a 1–4 bullet implementation approach, and an estimate for opening the first draft PR. Wait for maintainer assignment before coding. Only the assigned contributor is eligible for reward consideration.

Submission requirements

  • Use PR title format [#<issue-number>] <short summary>.
  • Check off each completed acceptance criterion.
  • Include focused automated tests for success, failure, authorization, and boundary behavior where applicable.
  • Include the validation commands and results in the PR description.
  • Address maintainer review feedback before merge.

GrantFox reward consideration is based on the original scope, implementation quality, tests, security review, CI/CD results, review feedback, and follow-up stability; completion or merge alone is not a guarantee.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    GRANTFOX OSSGrantFox open-source campaignMAYBE REWARDEDEligible for GrantFox rewardThird CampaignThird GrantFox campaignpriority:mediumMeaningful implementation work with medium difficulty

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions