Skip to content

Updated Reverse Geocoding Logic#207

Merged
cairocoder01 merged 3 commits into
DiscipleTools:masterfrom
jlamanskygitt:master
Jun 26, 2026
Merged

Updated Reverse Geocoding Logic#207
cairocoder01 merged 3 commits into
DiscipleTools:masterfrom
jlamanskygitt:master

Conversation

@jlamanskygitt

Copy link
Copy Markdown
Contributor

Updated the logic for reverse geocoding to be functional. Resolves #206

@netlify

netlify Bot commented Jun 22, 2026

Copy link
Copy Markdown

Deploy Preview for jade-chebakia-17493f ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 156c957
🔍 Latest deploy log https://app.netlify.com/projects/jade-chebakia-17493f/deploys/6a3e4839028f7f0008961e40
😎 Deploy Preview https://deploy-preview-207--jade-chebakia-17493f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cairocoder01 cairocoder01 self-assigned this Jun 24, 2026
@cairocoder01

Copy link
Copy Markdown
Collaborator

When I try to test this, nothing seems to happen when I click save in the map modal. I can console log in the onClose event and it gets there, but e.detail.action is undefined, so it doesn't dispatch the event. I think it's because the button is in a slot and those tend to act a little weird sometimes. So we need to make sure that the save button triggers the submit event and the data get all the way out to the geocode event.

Also, the map modal has no indicator what exact location it is selecting. If it's the middle of the map, can we put a pin icon over the center of the map where the base of the pin is the exact point on the map that is being selected?

@cairocoder01

Copy link
Copy Markdown
Collaborator

@jlamanskygitt Looks good! I just added the storybook action integration with the geocode event. I tested in the theme and it works great!

@cairocoder01
cairocoder01 merged commit abccd54 into DiscipleTools:master Jun 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Location-Map: reverse geocoding

3 participants