Workflow can't set boolean field

dt-workflows/workflows-execution-handler.php

@@ -154,7 +154,7 @@ private static function condition_equals( $field_type, $field, $value ): bool {
             case 'number':
                 return strval( $field ) === strval( $value );
             case 'boolean':
-                return boolval( $field ) === boolval( $value );
+                return (bool) filter_var( $field, FILTER_VALIDATE_BOOLEAN ) === (bool) filter_var( $value, FILTER_VALIDATE_BOOLEAN );
             case 'date':
                 // $value to be of epoch timestamp int type
                 return isset( $field['timestamp'] ) && intval( $field['timestamp'] ) === intval( $value );
@@ -169,7 +169,7 @@ private static function condition_not_equals( $field_type, $field, $value ): boo
             case 'number':
                 return strval( $field ) !== strval( $value );
             case 'boolean':
-                return boolval( $field ) !== boolval( $value );
+                return (bool) filter_var( $field, FILTER_VALIDATE_BOOLEAN ) !== (bool) filter_var( $value, FILTER_VALIDATE_BOOLEAN );
             case 'date':
                 return isset( $field['timestamp'] ) && intval( $field['timestamp'] ) !== intval( $value );
         }
@@ -535,11 +535,13 @@ private static function action_update( $field_type, $field_id, $value ): array {
         switch ( $field_type ) {
             case 'text':
             case 'number':
-            case 'boolean':
             case 'key_select':
             case 'user_select':
                 $updated[ $field_id ] = $value;
                 break;
+            case 'boolean':
+                $updated[ $field_id ] = (bool) filter_var( $value, FILTER_VALIDATE_BOOLEAN );
+                break;
             case 'date': // $value to be of epoch timestamp int type
                 $updated[ $field_id ] = $value === 'current' ? time() : $value;
                 break;

tests/dt-workflows/unit-test-boolean-update.php

@@ -0,0 +1,39 @@
+<?php
+class Unit_Test_Boolean_Update extends WP_UnitTestCase {
+    public function test_action_update_boolean() {
+        $method = new ReflectionMethod( 'Disciple_Tools_Workflows_Execution_Handler', 'action_update' );
+        $method->setAccessible( true );
+
+        // Test "true"
+        $result = $method->invoke( null, 'boolean', 'field_id', 'true' );
+        $this->assertEquals( [ 'field_id' => true ], $result );
+
+        // Test "false"
+        $result = $method->invoke( null, 'boolean', 'field_id', 'false' );
+        $this->assertEquals( [ 'field_id' => false ], $result );
+    }
+
+    public function test_condition_equals_boolean() {
+        $method = new ReflectionMethod( 'Disciple_Tools_Workflows_Execution_Handler', 'condition_equals' );
+        $method->setAccessible( true );
+
+        // Test "true" equals "true"
+        $this->assertTrue( $method->invoke( null, 'boolean', 'true', 'true' ) );
+        // Test "false" equals "false"
+        $this->assertTrue( $method->invoke( null, 'boolean', 'false', 'false' ) );
+        // Test "true" equals "false"
+        $this->assertFalse( $method->invoke( null, 'boolean', 'true', 'false' ) );
+    }
+
+    public function test_condition_not_equals_boolean() {
+        $method = new ReflectionMethod( 'Disciple_Tools_Workflows_Execution_Handler', 'condition_not_equals' );
+        $method->setAccessible( true );
+
+        // Test "true" not equals "false"
+        $this->assertTrue( $method->invoke( null, 'boolean', 'true', 'false' ) );
+        // Test "true" not equals "true"
+        $this->assertFalse( $method->invoke( null, 'boolean', 'true', 'true' ) );
+        // Test "false" not equals "false"
+        $this->assertFalse( $method->invoke( null, 'boolean', 'false', 'false' ) );
+    }
+}