AGT-787: partnerAuctionId to analytical module#68
Open
dmytro-po wants to merge 1 commit intorelease_0.35from
Open
AGT-787: partnerAuctionId to analytical module#68dmytro-po wants to merge 1 commit intorelease_0.35from
dmytro-po wants to merge 1 commit intorelease_0.35from
Conversation
| @@ -424,6 +429,7 @@ function constructFullUrl(data) { | |||
| const reportMethod = iiqAnalyticsAnalyticsAdapter.initOptions.reportMethod; | |||
| const partnerData = window[identityGlobalName]?.partnerData; | |||
| const currentBrowserLowerCase = detectBrowser(); | |||
| const partnerAuctionId = data.partnerAuctionId || 'BW'; | |||
Owner
There was a problem hiding this comment.
Let's use only data provided by partner without defaults, and send it only when we have it
| @@ -451,17 +458,17 @@ function constructFullUrl(data) { | |||
| (cmpData.gdprString ? '&gdpr_consent=' + encodeURIComponent(cmpData.gdprString) + '&gdpr=1' : '&gdpr=0'); | |||
| url = appendSPData(url, partnerData); | |||
| url = appendVrrefAndFui(url, iiqAnalyticsAnalyticsAdapter.initOptions.domainName); | |||
|
|
|||
| if (reportMethod === 'POST') { | |||
| @@ -387,7 +387,12 @@ function prepareData(data, result) { | |||
| } | |||
|
|
|||
| result.biddingPlatformId = data.biddingPlatformId || 1; | |||
| result.partnerAuctionId = 'BW'; | |||
|
|
|||
| if (isReportExternal && data && data.partnerAuctionId) { | |||
Owner
There was a problem hiding this comment.
Why do you need this drilling with isReportExternal? I'm pretty sure we don't have partnerAuctionId property in bidWon event. So why do we need this complicated logic and don't just use partnerAuctionId if we have it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information