Repository navigation
Replace opensubtitlescom _search recursion with a generator implementation - #1336
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
getzze
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I added some suggestions to simplify the code.
|
To mitigate this bug, since version |
4c5125f to
25b770d
Compare
Thx for the info, I was aware of it and thought about just setting a default page limit. But not doing (deep) recursion in a language that doesn't do tail call elimination sounded like a better way :) I replaced the usage of |
78fde4e to
6fa86ec
Compare
6fa86ec to
324cf79
Compare
|
Can you add a changelog entry, please? |
…ation It can happen that a opensubtitlescom query might return hundreds of pages, this can lead to a stackoverflow (especially on systems with a smaller default thread stack size like musl libc)
324cf79 to
558da58
Compare
|
Added |
|
Thank you for your contribution! |
…ation (Diaoul#1336) * Replace opensubtitlescom _search recursion with a generator implementation It can happen that a opensubtitlescom query might return hundreds of pages, this can lead to a stackoverflow (especially on systems with a smaller default thread stack size like musl libc)
It can happen that a opensubtitlescom query might return hundreds of
pages, this can lead to a stackoverflow (especially on systems with a
smaller default thread stack size like musl libc)