Fix empty WinGet update list on fresh launch + bump pinget to 0.9.0#4913
Merged
Merged
Conversation
On a cold start the WinGet update list was frequently empty or partial, only populating after a manual reload. _getAvailableUpdates runs `pinget source update` via Task.Run(RefreshPackageIndexes).Wait(60s) and then `pinget upgrade`; .Wait(timeout) does not cancel the task, so when source update runs longer than 60s the wait is abandoned and upgrade reads a half-rewritten index, returning 0 or partial results. The COM backend serialized winget access implicitly; the pinget/winget CLI backends did not. Add WinGet.AcquireCliLock(), a static reentrant lock wrapping every CLI invocation (PingetCliHelper.RunJson, WinGet.RefreshPackageIndexes, WinGetCliHelper query methods, PingetCliPackageDetailsProvider.RunPinget) so upgrade waits for source update to finish instead of racing it. Lock acquisition is bounded (Monitor.TryEnter, 120s): a hung CLI process falls back to running unserialized rather than freezing all WinGet queries. Also bump pinget to 0.9.0 (Cli.Rust for both apps, Core for the manager).
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a cold start the WinGet update list was frequently empty or partial, only populating after a manual reload. _getAvailableUpdates runs
pinget source updatevia Task.Run(RefreshPackageIndexes).Wait(60s) and thenpinget upgrade; .Wait(timeout) does not cancel the task, so when source update runs longer than 60s the wait is abandoned and upgrade reads a half-rewritten index, returning 0 or partial results. The COM backend serialized winget access implicitly; the pinget/winget CLI backends did not.Add WinGet.AcquireCliLock(), a static reentrant lock wrapping every CLI invocation (PingetCliHelper.RunJson, WinGet.RefreshPackageIndexes, WinGetCliHelper query methods, PingetCliPackageDetailsProvider.RunPinget) so upgrade waits for source update to finish instead of racing it. Lock acquisition is bounded (Monitor.TryEnter, 120s): a hung CLI process falls back to running unserialized rather than freezing all WinGet queries.
Also bump pinget to 0.9.0 (Cli.Rust for both apps, Core for the manager).