Flashio cleanup #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Exception 'java.io.IOException' is never thrown in the method. (⌘F1) Inspection info: Reports exceptions that are declared in a method's signature but never thrown by the method itself or its implementations/derivatives" So it's 100% safe to remove ;)
Contributor
|
Thank you for splitting this up. What is the purpose of this commit? Why is only the cache function having the throws attribute removed? I think Dfu.fetchFromDevice can throw an exception |
Contributor
Author
|
the other methods are part of the interface, where a throws declaration is present. |
Contributor
Author
|
frankly said, did not much thought about ... just followed IntelliJ IDEA suggestions ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from PR #6 , where it was recommended to split the PRs.
I hope it is OK, if I also add the .gitignore file here.