-
Notifications
You must be signed in to change notification settings - Fork 34
added contact us button and email validation #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Development
Are you sure you want to change the base?
Conversation
|
can you share a screenshot to show how Contact us is looking in smaller size such as mobile phones |
|
I haven't added it for the mobile view yet, i missed it. |
|
This is the mobile view @kaustubhai I have also added the required spacing between the buttons in mobile view which was lacking earlier |
|
i think we are not using the same source code files maybe, i cloned the whole code again yesterday itself and even now after your comment, but still it's showing to me that way only, ( the login button not aligned properly). |
|
@jainmudit68 yes there is bug in the bottom nav bar. |
|
@jainmudit68 contact us button is not required in mobile view it looks very wierd |
| > | ||
| {' '} | ||
| | ||
| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why there are so many spacing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the icons were looking too close in the mobile view so i increased the space between them.
Like the space between the first two icons originally was ok but others were too close to be distinguishable
| style={{ color: `${nav === 'contactus' ? 'wheat' : 'gray'}` }} | ||
| > | ||
| {' '} | ||
| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
| > | ||
| {' '} | ||
| | ||
| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here also




this closes issues #82 and #101 and is referenced with PR #104