Skip to content

Conversation

@jainmudit68
Copy link

this closes issues #82 and #101 and is referenced with PR #104

image

@kaustubhai
Copy link
Contributor

kaustubhai commented Jun 5, 2023

can you share a screenshot to show how Contact us is looking in smaller size such as mobile phones

@jainmudit68
Copy link
Author

I haven't added it for the mobile view yet, i missed it.
I will add it in a few minutes and attach it here

@jainmudit68
Copy link
Author

jainmudit68 commented Jun 5, 2023

image

This is the mobile view @kaustubhai

I have also added the required spacing between the buttons in mobile view which was lacking earlier

@kaustubhai
Copy link
Contributor

image

This doesnt look right

@jainmudit68
Copy link
Author

image

This doesnt look right

the alignment? -> it was already that way i just added one more button
the icon? -> it can be changed

@kaustubhai
Copy link
Contributor

image

The current alignment ☝️
Why is your login button that far?

@jainmudit68
Copy link
Author

i think we are not using the same source code files maybe, i cloned the whole code again yesterday itself and even now after your comment, but still it's showing to me that way only, ( the login button not aligned properly).

@varun-singhh
Copy link
Contributor

@jainmudit68 yes there is bug in the bottom nav bar.

@varun-singhh
Copy link
Contributor

@jainmudit68 contact us button is not required in mobile view it looks very wierd

>
{' '}
 
       
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why there are so many spacing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the icons were looking too close in the mobile view so i increased the space between them.
Like the space between the first two icons originally was ok but others were too close to be distinguishable

style={{ color: `${nav === 'contactus' ? 'wheat' : 'gray'}` }}
>
{' '}
       
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

>
{' '}
 
       
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here also

@varun-singhh varun-singhh added gssoc23 for only GSSOC'23 contributors level1 gssoc23 level (10 - Points) labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc23 for only GSSOC'23 contributors level1 gssoc23 level (10 - Points)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants