DataGrid: fix validation data object with repaintChangesOnly (T1323690)#32867
Merged
anna-shakhova merged 1 commit intoDevExpress:26_1from Mar 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DataGrid validation callback data payload when repaintChangesOnly is enabled, ensuring validators receive the correct row data after edits are reverted.
Changes:
- Adjusted
ValidatingController’sdataGetterto provide a non-empty data object when there is no active change for the row. - Added integration tests to verify
validationCallbackreceives real row data after reverting changes and merged (edited) row data during active editing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/validating/m_validating.ts | Updates validator dataGetter logic to supply appropriate row data when changes are absent/present. |
| packages/devextreme/js/__internal/grids/grid_core/validating/tests/validating.integration.test.ts | Adds regression tests for correct validationCallback data with repaintChangesOnly + revert/edit flows. |
packages/devextreme/js/__internal/grids/grid_core/validating/m_validating.ts
Show resolved
Hide resolved
Raushen
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.