content-agnostically join container into a string#11
Open
gsauthof wants to merge 1 commit into
Open
Conversation
and remove unused includes.
Before that change the function had the arguably surprising
pre-condition that the elements of the container need to be unique.
A caller who violates that pre-condition would get results such as:
[1 2 3 1] with delim "," => "12,3,1"
instead of the arguably naturally expected:
[1 2 3 1] with delim "," => "1,2,3,1"
Sure, perhaps your code checks elsewhere that the input is unique,
no sane user would ever provide non-unique input etc.
But having such a generically named function lying around in the
codebase arguably has the risk of being called on non-unique input,
at some point, arguably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and remove unused includes.
Before that change the function had the arguably surprising pre-condition that the elements of the container need to be unique.
A caller who violates that pre-condition would get results such as:
instead of the arguably naturally expected:
Sure, perhaps your code checks elsewhere that the input is unique, no sane user would ever provide non-unique input etc. But having such a generically named function lying around in the codebase arguably has the risk of being called on non-unique input, at some point, arguably.