Skip to content

fix: Resolve nullable parameter deprecation issue in PHP 8.4 #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DenverCoder1 merged 1 commit into from
Jul 26, 2026
+3 −3
Merged

fix: Resolve nullable parameter deprecation issue in PHP 8.4 #925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/card.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ function formatNumber(float $num, string $localeCode, bool $useShortNumbers): st
*
* @throws InvalidArgumentException If a locale does not exist
*/
function generateCard(array $stats, array $params = null): string
function generateCard(array $stats, ?array $params = null): string
{
$params = $params ?? $_REQUEST;

Expand Down Expand Up @@ -615,7 +615,7 @@ function generateCard(array $stats, array $params = null): string
* @param array<string,string>|NULL $params Request parameters
* @return string The generated SVG error card
*/
function generateErrorCard(string $message, array $params = null): string
function generateErrorCard(string $message, ?array $params = null): string
{
$params = $params ?? $_REQUEST;

Expand Down Expand Up @@ -807,7 +807,7 @@ function convertSvgToPng(string $svg, int $cardWidth, int $cardHeight): string
* @param int $errorCode The HTTP error code (used for JSON responses)
* @return array The Content-Type header and the response body, and status code in case of an error
*/
function generateOutput(string|array $output, array $params = null, int $errorCode = 200): array
function generateOutput(string|array $output, ?array $params = null, int $errorCode = 200): array
{
$params = $params ?? $_REQUEST;

Expand Down
Loading