Feature: Allow the user to access edgeloops#27
Open
glitchland wants to merge 4 commits intoDavidArayan:masterfrom
Open
Feature: Allow the user to access edgeloops#27glitchland wants to merge 4 commits intoDavidArayan:masterfrom
glitchland wants to merge 4 commits intoDavidArayan:masterfrom
Conversation
Owner
|
Always great to see contributions coming in, thank you for that! I'll do a quick test over the weekend and merge with master. Could you describe what the use-case of this change is? ie, what is an edgeloop cut? cheers! |
Author
|
Hiya @DavidArayan, sorry for the slow reply. So my use case was kinda strange I guess, I needed to take a series of cross sections of a mesh using a plane to emulate a 3d printer. I used that to build an extruder. I made this GIF of the functionality (it takes a little while to start running): https://i.imgur.com/b69bWUo.gif This would have taken me a long time if it were not for your amazing library, so I wanted to PR my code in case my changes can help someone else out the same way you helped me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your awesome work on this library. I added a few changes that allow the user to also explicitly request an edgeloop cut at a specified coordinate. For example:
Let me know if this is something that you think would be worth it to add to ezy-slice main, otherwise I can maintain it in my fork. I can also make any changes required to make it suitable for main.