Fix / Solve f4 dependency issue #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thapacodes4u
changed the title
SlimDeluxe
requested changes
Oct 13, 2025
SlimDeluxe
requested changes
Oct 13, 2025
Member
SlimDeluxe
left a comment
SlimDeluxe
left a comment
There was a problem hiding this comment.
Tests are failing:
There are problems in AdminPanelProvider, also duplicate plugin registration:
Contributor
Author
@SlimDeluxe Fixed |
Member
|
@thapacodes4u tests are still failing. Before marking as ready please make sure they pass both locally and in CI. |
Contributor
Author
Ya I just noticed it a bit late after notifying you. I will keep this in mind. Right now test are passing in the CI and local as well. @SlimDeluxe So it should be ready for review. |
SlimDeluxe
approved these changes
Oct 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket