Skip to content

remove docker prune before pulling images #4946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jul 15, 2025

Motivation

Running docker prune takes 5+ minutes, so we should instead use larger machines with more storage to run scenarios that need more space. Ideally we'd use smaller Docker images, but some of them are really difficult to reduce the size of as the software on them is large to begin with.

Fixes regression from DataDog/dd-trace-js#5884

Changes

Remove docker prune before pulling images.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@rochdev rochdev marked this pull request as ready for review July 16, 2025 00:01
@rochdev rochdev requested a review from a team as a code owner July 16, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants