Skip to content

Conversation

gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Oct 1, 2025

What does this PR do?

Does not build tar file in the build process, because CI does it anyways. This PR isolates responsibility:

  1. The CI infrastructure handles all tar creation.
  2. The individual build tools (like the release binary) only create directory structures

CI infrastructure creates tar creation here:

for triplet in x86_64-unknown-linux-gnu x86_64-alpine-linux-musl aarch64-unknown-linux-gnu aarch64-alpine-linux-musl ; do
      mv -v "${triplet}" "libdatadog-${triplet}"
      tar -cvf "artifacts/libdatadog-${triplet}.tar" "libdatadog-${triplet}/"
    done

If we build tar file also in the build step, like we do now:

    pub fn pack(&self) -> Result<()> {
        let tarname = "libdatadog".to_string() + "_v" + &self.version + ".tar";
        let path: PathBuf = [self.target_dir.as_ref(), &tarname].iter().collect();
        let artifact = fs::File::create(path).expect("Failed to create tarfile");
        let mut ar = tar::Builder::new(artifact);
        ar.append_dir_all("lib", self.target_lib.as_ref())?;
        ar.append_dir("bin", self.target_bin.as_ref())?;
        ar.append_dir_all("include/datadog", self.target_include.as_ref())?;


        ar.finish().expect("Failed to write the tarfile");
        Ok(())
    }

This leads to nested, duplicated files

This PR also adds necessary files LICENSE, LICENSE-3rdparty.yml, and NOTICE to releases through the build crate, which are requirements of OSS

NOTE: Windows still suffers from this issue; not because of the bug, but because Windows uses own pwshell script in libddprof-build. This will be fixed in follow up PR.

Motivation

Screenshot 2025-10-01 at 2 26 49 PM

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.
Take a look at artifacts here

Ticket: https://datadoghq.atlassian.net/jira/software/c/projects/PROF/boards/11?selectedIssue=PROF-12653

@gyuheon0h gyuheon0h requested a review from a team as a code owner October 1, 2025 18:12
@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-10-01 20:33:16

Comparing candidate commit 1c9c117 in PR branch gyuheon0h/release-binary-fix with baseline commit 902b6a5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.443µs 25.187µs ± 10.493µs 17.666µs ± 0.176µs 34.981µs 45.418µs 46.404µs 77.833µs 340.57% 1.350 2.306 41.56% 0.742µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.733µs; 26.642µs] or [-5.774%; +5.774%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.390ms 14.463ms ± 0.037ms 14.461ms ± 0.022ms 14.483ms 14.508ms 14.593ms 14.660ms 1.38% 1.418 4.850 0.25% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.458ms; 14.468ms] or [-0.035%; +0.035%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 186.541µs 186.897µs ± 0.193µs 186.876µs ± 0.123µs 187.013µs 187.163µs 187.247µs 188.181µs 0.70% 1.802 9.080 0.10% 0.014µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5314044.768op/s 5350557.199op/s ± 5512.889op/s 5351142.650op/s ± 3515.465op/s 5354371.193op/s 5357548.237op/s 5359074.139op/s 5360752.510op/s 0.18% -1.778 8.889 0.10% 389.820op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.570µs 17.697µs ± 0.083µs 17.676µs ± 0.031µs 17.710µs 17.907µs 17.954µs 18.003µs 1.85% 1.776 2.766 0.47% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 55545038.000op/s 56508137.222op/s ± 261388.077op/s 56573419.010op/s ± 98153.294op/s 56663109.577op/s 56780920.684op/s 56847473.071op/s 56914872.425op/s 0.60% -1.754 2.694 0.46% 18482.928op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 9.865µs 9.956µs ± 0.068µs 9.925µs ± 0.024µs 10.007µs 10.087µs 10.117µs 10.155µs 2.32% 1.016 -0.302 0.68% 0.005µs 1 200
normalization/normalize_name/normalize_name/good throughput 98472629.831op/s 100448905.978op/s ± 683269.830op/s 100753475.709op/s ± 246075.561op/s 100946430.167op/s 101098659.108op/s 101249557.624op/s 101369097.170op/s 0.61% -1.002 -0.337 0.68% 48314.473op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [186.870µs; 186.923µs] or [-0.014%; +0.014%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5349793.165op/s; 5351321.232op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.686µs; 17.708µs] or [-0.065%; +0.065%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [56471911.349op/s; 56544363.096op/s] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/good execution_time [9.946µs; 9.965µs] or [-0.095%; +0.095%] None None None
normalization/normalize_name/normalize_name/good throughput [100354211.351op/s; 100543600.605op/s] or [-0.094%; +0.094%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 240.195ns 251.607ns ± 13.544ns 245.983ns ± 4.277ns 256.889ns 285.605ns 292.896ns 298.126ns 21.20% 1.696 2.134 5.37% 0.958ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [249.730ns; 253.484ns] or [-0.746%; +0.746%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.889µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.917µs 3.918µs 3.918µs 0.15% -2.519 19.243 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255214530.919op/s 255605799.287op/s ± 189570.279op/s 255598808.432op/s ± 98379.817op/s 255693984.799op/s 255862025.910op/s 255967284.147op/s 257132743.648op/s 0.60% 2.553 19.569 0.07% 13404.643op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.853µs 78.550µs ± 0.855µs 78.548µs ± 0.605µs 79.146µs 80.096µs 80.477µs 80.600µs 2.61% 0.182 -0.506 1.09% 0.060µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12407010.426op/s 12732168.327op/s ± 138285.300op/s 12731067.046op/s ± 97329.476op/s 12834273.132op/s 12948625.717op/s 13000733.827op/s 13011816.763op/s 2.21% -0.135 -0.536 1.08% 9778.247op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 69.894µs 71.044µs ± 0.667µs 70.935µs ± 0.425µs 71.428µs 72.174µs 73.037µs 73.774µs 4.00% 0.795 1.041 0.94% 0.047µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13554939.612op/s 14077017.400op/s ± 131191.306op/s 14097504.237op/s ± 84257.441op/s 14166592.919op/s 14272264.091op/s 14305389.879op/s 14307294.092op/s 1.49% -0.729 0.843 0.93% 9276.626op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.891µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.917µs 3.920µs 3.922µs 0.25% -1.173 10.042 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254988861.564op/s 255613541.117op/s ± 204404.971op/s 255634889.797op/s ± 123772.283op/s 255745011.140op/s 255864450.486op/s 255936079.106op/s 257020261.680op/s 0.54% 1.199 10.226 0.08% 14453.614op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 66.807µs 68.099µs ± 0.614µs 68.042µs ± 0.427µs 68.481µs 69.175µs 69.589µs 70.498µs 3.61% 0.522 0.372 0.90% 0.043µs 1 200
credit_card/is_card_number/378282246310005 throughput 14184757.424op/s 14685594.516op/s ± 131923.723op/s 14696749.129op/s ± 92038.563op/s 14780197.505op/s 14863756.458op/s 14942096.987op/s 14968389.896op/s 1.85% -0.466 0.252 0.90% 9328.416op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.144µs 52.220µs ± 0.036µs 52.221µs ± 0.028µs 52.248µs 52.275µs 52.294µs 52.311µs 0.17% -0.089 -0.662 0.07% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19116407.772op/s 19149794.716op/s ± 13228.819op/s 19149547.649op/s ± 10112.059op/s 19159302.289op/s 19172410.518op/s 19177614.910op/s 19177801.695op/s 0.15% 0.092 -0.663 0.07% 935.419op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.025µs 6.034µs ± 0.008µs 6.033µs ± 0.002µs 6.036µs 6.042µs 6.073µs 6.108µs 1.25% 5.475 39.900 0.14% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163707216.062op/s 165720714.523op/s ± 222810.401op/s 165761253.308op/s ± 68021.049op/s 165821552.662op/s 165884352.195op/s 165945734.267op/s 165987383.157op/s 0.14% -5.427 39.293 0.13% 15755.075op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.893µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.917µs 3.919µs 0.19% -1.168 7.792 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255191495.878op/s 255671004.825op/s ± 180761.894op/s 255669161.310op/s ± 114289.501op/s 255786098.029op/s 255924334.443op/s 255958914.653op/s 256854670.964op/s 0.46% 1.186 7.919 0.07% 12781.796op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.074µs 64.454µs ± 0.168µs 64.436µs ± 0.112µs 64.552µs 64.770µs 64.872µs 64.977µs 0.84% 0.485 0.047 0.26% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15390077.800op/s 15514972.807op/s ± 40316.920op/s 15519264.905op/s ± 27081.982op/s 15546022.655op/s 15570258.082op/s 15602640.940op/s 15606915.424op/s 0.56% -0.471 0.031 0.26% 2850.837op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.085µs 58.354µs ± 0.152µs 58.318µs ± 0.083µs 58.450µs 58.650µs 58.805µs 59.018µs 1.20% 1.110 1.568 0.26% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16943986.530op/s 17136865.380op/s ± 44530.215op/s 17147259.318op/s ± 24454.061op/s 17168886.116op/s 17191146.217op/s 17201440.619op/s 17216150.471op/s 0.40% -1.092 1.498 0.26% 3148.762op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.917µs 3.919µs 3.921µs 0.22% -0.663 3.850 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255020033.440op/s 255589260.310op/s ± 199623.341op/s 255580844.216op/s ± 149348.025op/s 255731714.620op/s 255879944.179op/s 255939615.494op/s 256715196.485op/s 0.44% 0.676 3.918 0.08% 14115.502op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.559µs 54.849µs ± 0.231µs 54.782µs ± 0.131µs 54.954µs 55.291µs 55.541µs 55.732µs 1.73% 1.253 1.325 0.42% 0.016µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17943004.194op/s 18232265.615op/s ± 76506.564op/s 18254255.760op/s ± 43529.874op/s 18290688.212op/s 18312781.864op/s 18324186.463op/s 18328811.058op/s 0.41% -1.231 1.246 0.42% 5409.831op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.136µs 52.209µs ± 0.035µs 52.204µs ± 0.020µs 52.227µs 52.265µs 52.317µs 52.339µs 0.26% 0.879 1.432 0.07% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19106363.534op/s 19153931.274op/s ± 12662.689op/s 19155529.481op/s ± 7185.012op/s 19161687.165op/s 19173665.354op/s 19177100.854op/s 19180732.954op/s 0.13% -0.874 1.418 0.07% 895.387op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.026µs 6.038µs ± 0.019µs 6.034µs ± 0.003µs 6.037µs 6.067µs 6.132µs 6.183µs 2.47% 5.553 35.648 0.31% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 161741616.547op/s 165617187.246op/s ± 507050.059op/s 165736528.331op/s ± 81152.482op/s 165801756.683op/s 165873678.035op/s 165906589.374op/s 165943056.795op/s 0.12% -5.490 34.903 0.31% 35853.854op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255579526.669op/s; 255632071.904op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.432µs; 78.669µs] or [-0.151%; +0.151%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12713003.314op/s; 12751333.339op/s] or [-0.151%; +0.151%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [70.952µs; 71.136µs] or [-0.130%; +0.130%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14058835.547op/s; 14095199.253op/s] or [-0.129%; +0.129%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255585212.554op/s; 255641869.680op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.014µs; 68.185µs] or [-0.125%; +0.125%] None None None
credit_card/is_card_number/378282246310005 throughput [14667311.157op/s; 14703877.876op/s] or [-0.124%; +0.124%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.215µs; 52.225µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19147961.329op/s; 19151628.103op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.033µs; 6.035µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/x371413321323331 throughput [165689835.145op/s; 165751593.902op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255645952.965op/s; 255696056.685op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.431µs; 64.478µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15509385.269op/s; 15520560.344op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.333µs; 58.375µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17130693.921op/s; 17143036.840op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255561594.435op/s; 255616926.185op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.817µs; 54.881µs] or [-0.058%; +0.058%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18221662.541op/s; 18242868.689op/s] or [-0.058%; +0.058%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.204µs; 52.213µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19152176.347op/s; 19155686.201op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.035µs; 6.041µs] or [-0.043%; +0.043%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165546914.984op/s; 165687459.508op/s] or [-0.042%; +0.042%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.452ms 10.481ms ± 0.013ms 10.479ms ± 0.009ms 10.489ms 10.503ms 10.513ms 10.551ms 0.69% 0.979 2.846 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.479ms; 10.483ms] or [-0.018%; +0.018%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.364µs 535.139µs ± 0.527µs 535.100µs ± 0.270µs 535.349µs 535.809µs 536.248µs 540.079µs 0.93% 4.248 36.796 0.10% 0.037µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1851580.367op/s 1868674.754op/s ± 1834.265op/s 1868808.747op/s ± 943.066op/s 1869775.061op/s 1870824.921op/s 1871320.656op/s 1871384.787op/s 0.14% -4.187 36.048 0.10% 129.702op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 379.686µs 380.367µs ± 0.380µs 380.338µs ± 0.215µs 380.551µs 380.964µs 381.310µs 382.744µs 0.63% 2.180 10.638 0.10% 0.027µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2612715.381op/s 2629045.500op/s ± 2621.710op/s 2629239.105op/s ± 1484.707op/s 2630741.264op/s 2632547.102op/s 2633545.166op/s 2633752.547op/s 0.17% -2.156 10.470 0.10% 185.383op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 193.708µs 194.145µs ± 0.337µs 194.101µs ± 0.138µs 194.248µs 194.513µs 194.783µs 197.776µs 1.89% 6.448 65.822 0.17% 0.024µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5056237.334op/s 5150814.724op/s ± 8838.288op/s 5151954.177op/s ± 3673.533op/s 5155426.966op/s 5159730.280op/s 5160737.472op/s 5162398.178op/s 0.20% -6.313 63.859 0.17% 624.961op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 35.982µs 36.153µs ± 0.118µs 36.139µs ± 0.047µs 36.188µs 36.282µs 36.374µs 37.412µs 3.52% 6.302 64.049 0.32% 0.008µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26729141.170op/s 27660583.434op/s ± 88199.460op/s 27671117.635op/s ± 36001.037op/s 27706585.036op/s 27743874.804op/s 27777463.314op/s 27791327.381op/s 0.43% -6.051 60.445 0.32% 6236.644op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.908µs 45.094µs ± 0.169µs 45.079µs ± 0.144µs 45.218µs 45.332µs 45.367µs 46.289µs 2.69% 1.865 10.644 0.37% 0.012µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21603223.201op/s 22176411.236op/s ± 82469.947op/s 22183395.820op/s ± 70637.210op/s 22260446.986op/s 22265915.370op/s 22266673.154op/s 22267598.640op/s 0.38% -1.765 9.740 0.37% 5831.506op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [535.066µs; 535.212µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1868420.542op/s; 1868928.965op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.314µs; 380.419µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2628682.156op/s; 2629408.843op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [194.098µs; 194.191µs] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5149589.822op/s; 5152039.626op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.137µs; 36.169µs] or [-0.045%; +0.045%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27648359.837op/s; 27672807.031op/s] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.070µs; 45.117µs] or [-0.052%; +0.052%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22164981.694op/s; 22187840.777op/s] or [-0.052%; +0.052%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 6.180ms 6.242ms ± 0.038ms 6.233ms ± 0.017ms 6.251ms 6.339ms 6.377ms 6.389ms 2.50% 1.799 3.623 0.61% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [6.237ms; 6.247ms] or [-0.085%; +0.085%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 156.388µs 157.163µs ± 0.286µs 157.111µs ± 0.122µs 157.272µs 157.664µs 157.940µs 159.091µs 1.26% 2.067 10.116 0.18% 0.020µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [157.123µs; 157.202µs] or [-0.025%; +0.025%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.003µs 34.482µs ± 0.806µs 34.121µs ± 0.056µs 34.220µs 36.145µs 36.185µs 38.251µs 12.10% 1.889 2.446 2.33% 0.057µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.370µs; 34.594µs] or [-0.324%; +0.324%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 86.955µs 87.337µs ± 0.194µs 87.310µs ± 0.057µs 87.384µs 87.519µs 87.680µs 89.583µs 2.60% 7.921 87.698 0.22% 0.014µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [87.310µs; 87.364µs] or [-0.031%; +0.031%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.328µs 2.408µs ± 0.021µs 2.409µs ± 0.005µs 2.417µs 2.432µs 2.435µs 2.441µs 1.31% -2.171 5.501 0.85% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.405µs; 2.411µs] or [-0.118%; +0.118%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.256ms 60.707ms ± 2.536ms 60.384ms ± 0.051ms 60.437ms 60.573ms 80.037ms 82.934ms 37.34% 8.014 62.568 4.17% 0.179ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.355ms; 61.058ms] or [-0.579%; +0.579%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.159µs 3.175µs ± 1.440µs 2.969µs ± 0.021µs 2.990µs 3.635µs 13.953µs 15.033µs 406.27% 7.389 55.607 45.26% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.975µs; 3.375µs] or [-6.288%; +6.288%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1c9c117 1759344348 gyuheon0h/release-binary-fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.964µs 5.038µs ± 0.039µs 5.026µs ± 0.024µs 5.065µs 5.106µs 5.111µs 5.112µs 1.73% 0.389 -0.915 0.78% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.032µs; 5.043µs] or [-0.108%; +0.108%] None None None

Baseline

Omitted due to size.

@gyuheon0h gyuheon0h requested review from ivoanjo and gleocadie October 1, 2025 18:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.66%. Comparing base (902b6a5) to head (1c9c117).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
- Coverage   71.67%   71.66%   -0.01%     
==========================================
  Files         355      355              
  Lines       56443    56457      +14     
==========================================
+ Hits        40454    40459       +5     
- Misses      15989    15998       +9     
Components Coverage Δ
datadog-crashtracker 49.30% <ø> (ø)
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.47% <ø> (ø)
data-pipeline-ffi 88.19% <ø> (ø)
ddcommon 84.54% <ø> (ø)
ddcommon-ffi 73.84% <ø> (ø)
ddtelemetry 59.49% <ø> (+0.03%) ⬆️
ddtelemetry-ffi 21.24% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.39% <ø> (ø)
datadog-profiling 76.90% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 37.19% <ø> (ø)
datdog-sidecar-ffi 11.87% <ø> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 92.22% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 59.65% <ø> (ø)
datadog-trace-utils 89.77% <ø> (ø)
datadog-tracer-flare 54.52% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dd-octo-sts
Copy link

dd-octo-sts bot commented Oct 1, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.25 MB 7.25 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 71.29 MB 71.29 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.27 MB 9.27 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 83.62 MB 83.62 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 18.47 MB 18.47 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 125.29 MB 125.28 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 654.82 MB 654.82 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.92 MB 5.92 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.44 MB 17.44 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 32.39 MB 32.39 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 15.75 MB 15.75 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 127.62 MB 127.62 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 645.00 MB 645.00 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.53 MB 4.53 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.57 MB 18.57 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 30.42 MB 30.42 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 63.91 MB 63.91 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.56 MB 8.56 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 78.33 MB 78.33 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.91 MB 9.91 MB 0% (0 B) 👌

Copy link

datadog-official bot commented Oct 1, 2025

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

test_ddog_sidecar_register_app from datadog-sidecar-ffi::sidecar (Datadog) (✨ Fix with BitsAI)
thread 'test_ddog_sidecar_register_app' panicked at D:\a\libdatadog\libdatadog\ddcommon-ffi\src\option.rs:34:32

thread 'test_ddog_sidecar_register_app' panicked at D:\a\libdatadog\libdatadog\ddcommon-ffi\src\option.rs:34:32:
Called ffi::Option::unwrap_none but option was Some(_)
stack backtrace:
   0:     0x7ff619cdcbf2 - std::backtrace_rs::backtrace::win64::trace
                               at /rustc/29483883eed69d5fb4db01964cdf2af4d86e9cb2/library\std\src\..\..\backtrace\src\backtrace\win64.rs:85
   1:     0x7ff619cdcbf2 - std::backtrace_rs::backtrace::trace_unsynchronized
                               at /rustc/29483883eed69d5fb4db01964cdf2af4d86e9cb2/library\std\src\..\..\backtrace\src\backtrace\mod.rs:66
   2:     0x7ff619cdcbf2 - std::sys::backtrace::_print_fmt
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1c9c117 | Docs | Was this helpful? Give us feedback!

Copy link
Contributor

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyuheon0h
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 1, 2025

View all feedbacks in Devflow UI.

2025-10-01 19:46:52 UTC ℹ️ Start processing command /merge


2025-10-01 19:47:13 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).


2025-10-01 20:07:40 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit e6a72a7:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@gyuheon0h
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 1, 2025

View all feedbacks in Devflow UI.

2025-10-01 20:09:11 UTC ℹ️ Start processing command /merge


2025-10-01 20:09:16 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).


2025-10-01 20:30:43 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit 34e865b:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@gyuheon0h
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 1, 2025

View all feedbacks in Devflow UI.

2025-10-01 20:31:40 UTC ℹ️ Start processing command /merge


2025-10-01 20:31:45 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).


2025-10-01 20:50:16 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 4ad519f into main Oct 1, 2025
45 of 48 checks passed
@dd-mergequeue dd-mergequeue bot deleted the gyuheon0h/release-binary-fix branch October 1, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants