-
Notifications
You must be signed in to change notification settings - Fork 15
[libdatadog] Fix release building nested tar files #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksComparisonBenchmark execution time: 2025-10-01 20:33:16 Comparing candidate commit 1c9c117 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
- Coverage 71.67% 71.66% -0.01%
==========================================
Files 355 355
Lines 56443 56457 +14
==========================================
+ Hits 40454 40459 +5
- Misses 15989 15998 +9
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit e6a72a7: What to do next?
|
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit 34e865b: What to do next?
|
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Does not build tar file in the build process, because CI does it anyways. This PR isolates responsibility:
CI infrastructure creates tar creation here:
If we build tar file also in the build step, like we do now:
This leads to nested, duplicated files
This PR also adds necessary files
LICENSE
,LICENSE-3rdparty.yml
, andNOTICE
to releases through the build crate, which are requirements of OSSNOTE: Windows still suffers from this issue; not because of the bug, but because Windows uses own pwshell script in
libddprof-build
. This will be fixed in follow up PR.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.
Take a look at artifacts here
Ticket: https://datadoghq.atlassian.net/jira/software/c/projects/PROF/boards/11?selectedIssue=PROF-12653