-
Notifications
You must be signed in to change notification settings - Fork 13
attempt to reduce flakiness of trace exporter shutdown tests #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to reduce flakiness of trace exporter shutdown tests #1128
Conversation
56b6eef
to
3e8a609
Compare
BenchmarksComparisonBenchmark execution time: 2025-07-22 20:40:48 Comparing candidate commit e5ff9fe in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1128 +/- ##
==========================================
- Coverage 71.30% 71.27% -0.03%
==========================================
Files 345 345
Lines 53148 53174 +26
==========================================
+ Hits 37898 37901 +3
- Misses 15250 15273 +23
🚀 New features to boost your workflow:
|
3e8a609
to
e5ff9fe
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit 071c9b4: What to do next?
|
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Attempts to reduce the likelihood of the trace exporter shutdown unit tests flaking on CI by:
AGENT_INFO_CACHE
to beSome
instead of checking the mock/info
endpoint is hit. This is a potential race condition in tests as there is a non-zero amount of time between the endpoint being hit, the cache being populated, and the exporter checking the cache to know if it should enable the stats worker.Motivation
Flaky tests aren't cool
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.