Support use of snakeyaml-engine on java 8+ and legacy snakeyaml on Java 7#585
Open
Support use of snakeyaml-engine on java 8+ and legacy snakeyaml on Java 7#585
snakeyaml-engine on java 8+ and legacy snakeyaml on Java 7#585Conversation
mcculls
force-pushed
the
mcculls/use-snakeyaml-engine-on-java8
branch
from
1249d98 to
bddeb5d
Compare
mcculls
force-pushed
the
mcculls/use-snakeyaml-engine-on-java8
branch
from
bddeb5d to
631025a
Compare
mcculls
changed the title
snakeyaml-engine on java 8+ and legacy snakeyaml on Java 7snakeyaml-engine on java 8+ and legacy snakeyaml on Java 7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note the default "jar-with-dependencies" artifact still only contains the legacy
snakeyamllibrary, to avoid any increase in its size. If we wanted to include bothsnakeyamlandsnakeyaml-enginelibraries then "jar-with-dependencies" would increase by ~290KbAt runtime the appropriate YAML parser is loaded based on the Java version and which library is available on the runtime class-path.
This means downstream consumers that only use Java 8+ can decide to include the
snakeyaml-enginelibrary when embedding JMXFetch and skip the legacysnakeyamllibrary.