Draft
Conversation
bric3
force-pushed
the
bdu/testability-of-default-metrics
branch
from
58596ae to
032c64b
Compare
# Conflicts: # src/main/java/org/datadog/jmxfetch/Instance.java
bric3
force-pushed
the
bdu/testability-of-default-metrics
branch
from
032c64b to
f79bffc
Compare
…efaultConfig was false When useSimplifiedDefaultConfig is false, defaultConfig is an empty string, which creates a line with just 8 spaces in the YAML file. This isn't ideal YAML formatting and could potentially cause issues with YAML parsers.
- Replace unavailable openjdk:7-jdk image with azul/zulu-openjdk:7 - Remove docker/setup-docker-action as Docker is pre-installed on GitHub runners
bric3
force-pushed
the
bdu/testability-of-default-metrics
branch
from
ce262f5 to
3556c8c
Compare
After renaming the test's default-jmx-metrics.yaml to simplified-default-jmx-metrics.yaml in 279048f, the test was loading the full production default metrics instead of the simplified version, causing the test to collect 28 metrics instead of the expected 14. This fix explicitly sets default-jmx-metrics-definitions to use the simplified version.
bric3
force-pushed
the
bdu/testability-of-default-metrics
branch
from
668d63e to
1703a07
Compare
- Add simplified-default-jmx-metrics.yaml to jmx_0 instances in service discovery configs - Update testServiceDiscovery expectation from 63 to 35 metrics to match simplified defaults - testServiceDiscoveryLong already had correct expectation (35 metrics) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test for ZGC Memory pools, for both generational and non-generational.
For this to happen, this introduces a mechanism to replace the default configuration, it has to be in the same package
org/datadog/jmxfetch.Also fixed a file descriptor leak when reading default config, and the use of a raw FIS.