Skip to content

Fix error reporting not shown when running model validation #20445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: aarake/aarakke/fix-ddev-worktrees-behavior
Choose a base branch
from

Conversation

AAraKKe
Copy link
Contributor

@AAraKKe AAraKKe commented Jun 4, 2025

What does this PR do?

Fix ddev error reporting when validating config files.

Note: this is a stack on the previous PR because I was building a new integration with the worktrees fix to avoid any modification to take to long to validate, lint or format.

Motivation

When running ddev validate config if the schema of the spec is malformed the validation fails but errors are not reported because we skip the update before updating the display_queue. This update would allow us to get information about what failed when parsing the spec file.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link
Contributor Author

AAraKKe commented Jun 4, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Jun 4, 2025 — with Graphite App
@AAraKKe AAraKKe force-pushed the aarake/fix-error-reporting-on-model-validation branch from a92e2cc to 8b86313 Compare June 4, 2025 18:51
@AAraKKe AAraKKe force-pushed the aarake/aarakke/fix-ddev-worktrees-behavior branch from 4032e64 to 40b3696 Compare June 4, 2025 18:51
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (8a1befa) to head (166494e).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
datadog_checks_dev 77.61% <ø> (ø)
falco ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
kuma ?
litellm ?
mac_audit_logs ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AAraKKe AAraKKe force-pushed the aarake/fix-error-reporting-on-model-validation branch from 8b86313 to b1732ff Compare June 6, 2025 15:09
@AAraKKe AAraKKe force-pushed the aarake/aarakke/fix-ddev-worktrees-behavior branch 2 times, most recently from 8123d85 to c257725 Compare June 6, 2025 15:10
@AAraKKe AAraKKe force-pushed the aarake/fix-error-reporting-on-model-validation branch from b1732ff to f108fc0 Compare June 6, 2025 15:10
@AAraKKe AAraKKe force-pushed the aarake/aarakke/fix-ddev-worktrees-behavior branch from c257725 to 4ed2df5 Compare June 6, 2025 15:37
@AAraKKe AAraKKe force-pushed the aarake/fix-error-reporting-on-model-validation branch from f108fc0 to f7e8765 Compare June 6, 2025 15:37
@AAraKKe AAraKKe force-pushed the aarake/aarakke/fix-ddev-worktrees-behavior branch from 4ed2df5 to a5d2de5 Compare June 9, 2025 15:44
@AAraKKe AAraKKe force-pushed the aarake/fix-error-reporting-on-model-validation branch 2 times, most recently from b4e4cd0 to 555fe16 Compare June 9, 2025 15:53
@AAraKKe AAraKKe force-pushed the aarake/aarakke/fix-ddev-worktrees-behavior branch from a5d2de5 to 664d499 Compare June 9, 2025 15:56
@AAraKKe AAraKKe force-pushed the aarake/fix-error-reporting-on-model-validation branch 2 times, most recently from 5163c13 to cdb1f25 Compare June 10, 2025 08:40
@AAraKKe AAraKKe force-pushed the aarake/aarakke/fix-ddev-worktrees-behavior branch from 664d499 to 9db7543 Compare June 10, 2025 08:40
@AAraKKe AAraKKe force-pushed the aarake/fix-error-reporting-on-model-validation branch from cdb1f25 to 55358c2 Compare June 10, 2025 08:44
@AAraKKe AAraKKe marked this pull request as ready for review June 10, 2025 08:56
@AAraKKe AAraKKe requested a review from a team as a code owner June 10, 2025 08:56
@AAraKKe AAraKKe force-pushed the aarake/aarakke/fix-ddev-worktrees-behavior branch from 9db7543 to ba1d03b Compare June 10, 2025 12:29
@AAraKKe AAraKKe force-pushed the aarake/fix-error-reporting-on-model-validation branch from 6871b81 to 619123a Compare June 10, 2025 12:29
@AAraKKe AAraKKe force-pushed the aarake/fix-error-reporting-on-model-validation branch from 619123a to 3acb7bf Compare June 10, 2025 12:41
@AAraKKe AAraKKe force-pushed the aarake/aarakke/fix-ddev-worktrees-behavior branch from ba1d03b to 215a615 Compare June 10, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants