-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix error reporting not shown when running model validation #20445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: aarake/aarakke/fix-ddev-worktrees-behavior
Are you sure you want to change the base?
Fix error reporting not shown when running model validation #20445
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a92e2cc
to
8b86313
Compare
4032e64
to
40b3696
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
8b86313
to
b1732ff
Compare
8123d85
to
c257725
Compare
b1732ff
to
f108fc0
Compare
c257725
to
4ed2df5
Compare
f108fc0
to
f7e8765
Compare
4ed2df5
to
a5d2de5
Compare
b4e4cd0
to
555fe16
Compare
a5d2de5
to
664d499
Compare
5163c13
to
cdb1f25
Compare
664d499
to
9db7543
Compare
cdb1f25
to
55358c2
Compare
9db7543
to
ba1d03b
Compare
6871b81
to
619123a
Compare
Co-authored-by: dkirov-dd <[email protected]>
619123a
to
3acb7bf
Compare
ba1d03b
to
215a615
Compare
…/fix-error-reporting-on-model-validation
What does this PR do?
Fix ddev error reporting when validating config files.
Note: this is a stack on the previous PR because I was building a new integration with the worktrees fix to avoid any modification to take to long to validate, lint or format.
Motivation
When running
ddev validate config
if the schema of the spec is malformed the validation fails but errors are not reported because we skip the update before updating thedisplay_queue
. This update would allow us to get information about what failed when parsing the spec file.Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged