-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add support for Vagrant VMs in testing #20353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NouemanKHAL
wants to merge
84
commits into
master
Choose a base branch
from
noueman/add-support-for-vms-in-testing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,608
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vm_run
context manager for testing
dkirov-dd
requested changes
Jul 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look great to me, added a few comments and suggestions
joepeeples
approved these changes
Jul 22, 2025
dkirov-dd
previously approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Review from dkirov-dd is dismissed. Related teams and files:
- agent-integrations
- datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/config.py
dkirov-dd
approved these changes
Jul 24, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ddev
dependencies
dev_package
dev/tooling
documentation
integration/glusterfs
qa/skip-qa
Automatically skip this PR for the next QA
release
team/agent-integrations
team/documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for running E2E tests on VMs.
Updates the AgentInterface to pass the entire Application object which includes logging functionalities from the Terminal base class and access to ddev config via the
self.config
member.Uses the
E2E_METADATA
as an interface to customize the VM via the following properties:VM Configuration
vagrant_box
: Specifies the Vagrant box image (defaults to"net9/ubuntu-24.04-arm64"
)vagrant_guest_os
: Determines OS type ("linux"
or"windows"
not supported yet) for path formatting and commandsvagrant_synced_folders
: List of additional folders to sync between host and VMAgent Configuration
env
: Dictionary of environment variables to export in the VMdd_hostname
: Custom hostname for the Agentdd_apm_enabled
: Enable/disable APM (defaults to"false"
)dd_telemetry_enabled
: Enable/disable telemetry (defaults to"true"
)dd_expvar_port
: Port for expvar endpoint (defaults to"5000"
)proxy
: HTTP/HTTPS proxy configurationLifecycle Commands
start_commands
: List of shell commands to run during VM startuppost_install_commands
: Commands to run after local package installationstop_commands
: Commands to execute before VM shutdownPermission Management
vagrant_sudoers_config
: Custom sudoers rules fordd-agent
uservagrant_logs_require_sudo
: Whether sudo is needed to read agent logs (defaults totrue
)vagrant_command_needs_sudo
: Global sudo requirement flagProvisioning Control
vagrant_provision
: Flag to force provisioning on nextvagrant up
vagrant_provision_on_reload
: Whether to reprovision on VM reload (defaults totrue
)Windows-specific
vagrant_windows_agent_service_name
: Service name for Windows Agent (defaults to"DatadogAgent"
)Motivation
Provide better E2E testing for host based integrations.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged