Skip to content

Allow for special characters in sqlserver pwds #20166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lucaloncar-dd
Copy link
Contributor

What does this PR do?

Solves https://datadoghq.atlassian.net/browse/DBMON-737

Motivation

https://datadoghq.atlassian.net/browse/DBMON-737

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.27%. Comparing base (d3e5090) to head (d60baac).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 87.71% <40.00%> (+1.53%) ⬆️
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucaloncar-dd lucaloncar-dd changed the title WIP: allow for special characters in sqlserver pwds Allow for special characters in sqlserver pwds Apr 28, 2025
@lucaloncar-dd lucaloncar-dd force-pushed the luca.loncar/sql_server_pwd_fix branch 3 times, most recently from d0ba237 to 276306b Compare May 2, 2025 20:47
@lucaloncar-dd lucaloncar-dd force-pushed the luca.loncar/sql_server_pwd_fix branch from e080b39 to 385bc4a Compare May 6, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant