refactor: simplify runtime metrics collection architecture #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove runtimeMetricStore abstraction and move functionality directly into Emitter. This reduces complexity by eliminating the intermediate layer and makes the code more straightforward to understand and maintain. Changes: - Move metrics map, statsd client, logger, and tags directly to Emitter - Convert runtimeMetricStore methods to Emitter methods - Update tests to work with simplified architecture - Maintain all existing functionality and behavior 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Changing my mind on this. Moving everything into the Emitter makes it harder to test. The stuff produced by Claude "works", but I smell race conditions. So given the deadlines, I think we should press forward and keep the current code structure as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove runtimeMetricStore abstraction and move functionality directly into Emitter. This reduces complexity by eliminating the intermediate layer and makes the code more straightforward to understand and maintain.
Changes:
🤖 Generated with Claude Code.