Fix http.route tag not set on Rails 8.1+#5518
Merged
vpellan merged 4 commits intoDataDog:masterfrom Apr 2, 2026
Merged
Conversation
Rails 8.1 inlined the body of `ActionDispatch::Journey::Router#find_routes` directly into `recognize`, removing `find_routes` as a separate method. The existing `LazyRouter` patch targets `find_routes`, so it silently had no effect on Rails 8.1+, causing `http.route` to never be set on the `rack.request` span. Add a `RecognizeRouter` module that patches `recognize` instead, and update the patcher's version gate to select it for ActionPack >= 8.1. Two implementation details specific to Rails 8.1: - Use delete_suffix instead of delete_suffix! as route.path.spec.to_s returns a frozen string. - Capture SCRIPT_NAME before calling super, as recognize modifies req.script_name for mounted apps before yielding to the block. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closed
mabdinur
approved these changes
Apr 1, 2026
vpellan
approved these changes
Apr 2, 2026
Contributor
|
👋 Hey @nhosoya thank you very much for your contribution! We're going to merge this PR and it should be available in the next release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
RecognizeRoutermodule that patchesActionDispatch::Journey::Router#recognizefor Rails >= 8.1, and updates the version gate inPatcher#patchto use it. Also adds Rails 8.1 appraisals.Motivation:
Rails 8.1 removed the private
find_routesmethod by inlining its body directly intorecognize(rails/rails@e533a32). As a result, the existingLazyRouteroverride offind_routesbecame a no-op on Rails 8.1+, andhttp.routewas never set on therack.requestspan.Closes #5516
Change log entry
Additional Notes:
How to test the change?