publish rails application name to Process Discovery after initialization#5504
publish rails application name to Process Discovery after initialization#5504
Conversation
…il causing underscore to fail.
…nd update tests and utils to fail safely.
Co-authored-by: Sergey Fedorov <oni.strech@gmail.com>
… other features like profiling only apps can get the rails app name, remove the interaction of rails specific logic inside the process tags logic and clean up tests
…ils::Railtie:Class error
… new tag after rails initializes
…tions because we only want to send the information once
BenchmarksBenchmark execution time: 2026-03-27 19:39:10 Comparing candidate commit 5913f2d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 0 unstable metrics.
|
p-datadog
left a comment
There was a problem hiding this comment.
Looks good overall — had a question about what happens during reconfiguration.
…ug right now where memfd doesn't exist in a Rails app that gets reconfigured
…ish-again-for-memfd-rails-app-name
…ish-again-for-memfd-rails-app-name
…ish-again-for-memfd-rails-app-name
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 9d1bddc | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
What does this PR do?
Calls on Process Discovery to publish after getting access to the rails application name.
Motivation:
This came up while @raphaelgavache was explaining to me how process discovery works. This PR is a follow up to #5468, because the default behavior for Process Discovery is to publish the tags before the rails app has initialized.
This ensures we publish once after we obtain the right information.
Change log entry
Additional Notes:
Yes. Since folks are already reviewing #5468, I didn't want to complicate that PR with this change.
How to test the change?