Skip to content

Add typing for AppSec::Response#to_rack, HashCoercion, and Forking #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
marcotc wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add typing for AppSec::Response#to_rack, HashCoercion, and Forking #5456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sig/datadog/appsec/response.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module Datadog


def initialize: (status: ::Integer, ?headers: ::Hash[::String, ::String], ?body: ::Array[::String]) -> void
def to_rack: () -> ::Array[untyped]
def to_rack: () -> [::Integer, ::Hash[::String, ::String], ::Array[::String]]

def self.from_interrupt_params: (::Hash[::String, ::String] interrupt_params, ::String http_accept_header) -> Response

Expand Down
2 changes: 1 addition & 1 deletion sig/datadog/appsec/utils/hash_coercion.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module Datadog
module AppSec
module Utils
module HashCoercion
def self.coerce: (untyped) -> ::Hash[untyped, untyped]?
def self.coerce: (any) -> ::Hash[any, any]?
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions sig/datadog/core/utils/forking.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ module Datadog
module Forking
@fork_pid: Integer

def self.included: (untyped base) -> untyped
def self.included: (::Module base) -> void

def self.extended: (untyped base) -> untyped
def self.extended: (::Module base) -> void

def after_fork!: () { () -> untyped } -> bool

Expand Down
Loading