Add typing for Base64, TagBuilder, and Workers::Polling#stop#5455
Add typing for Base64, TagBuilder, and Workers::Polling#stop#5455
Conversation
- Base64: add :: prefixes to all String types; strict_decode64 arg typed as ::String (decode is format-dependent; return remains untyped) - TagBuilder: add :: prefixes; tags() accepts any settings (DSL object) - Polling#stop: untyped -> bool (always returns true/false from join/terminate) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
BenchmarksBenchmark execution time: 2026-03-13 21:02:42 Comparing candidate commit 3e1d1b0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 0 unstable metrics.
|
What does this PR do?
Small type improvements:
Utils::Base64:::prefixes added to allStringtypes;strict_decode64arg typed as::String(return remainsuntyped—unpack1return type is format-dependent and Steep can't narrow it)TagBuilder:::prefixes on all types;tags()acceptsanysettings (DSL settings object is intentionally open)Workers::Polling#stop:untyped→bool(always returnstrue/falsefromjoin/terminate)How to test the change?
bundle exec steep check \ lib/datadog/core/utils/base64.rb \ lib/datadog/core/tag_builder.rb \ lib/datadog/core/workers/polling.rbChangelog
None.