Add typing for AppSec::SecurityEngine::Runner#try_run#5452
Add typing for AppSec::SecurityEngine::Runner#try_run#5452
Conversation
Change `untyped timeout` to `::Integer timeout` in the private `try_run` method, matching the `run` public method signature and the WAF::Context#run stub in vendor/rbs/libddwaf-stub. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
👋 Hey @marcotc, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md(possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None.(possible answers No/Nope/None) Visited at: 2026-03-13 19:38:25 UTC |
Typing analysisNote: Ignored files are excluded from the next sections. Untyped methodsThis PR clears 1 partially typed method. It increases the percentage of typed methods from 61.14% to 61.19% (+0.05%). Partially typed methods (+0-1)✅ Cleared: |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: d7e5a27 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
BenchmarksBenchmark execution time: 2026-03-13 20:13:15 Comparing candidate commit d7e5a27 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 0 unstable metrics.
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
What does this PR do?
Types the
timeoutparameter of the privatetry_runmethod inAppSec::SecurityEngine::Runnerfromuntypedto::Integer, matching:runmethod signature (already typed as?::Integer timeout)WAF::Context#runstub invendor/rbs/libddwaf-stubMotivation
Reduces
untypedusage in AppSec security engine typing.How to test the change?
bundle exec steep check lib/datadog/appsec/security_engine/runner.rbChangelog
None.