Skip to content

Improve SSI #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 15, 2025
Merged

Improve SSI #4366

merged 10 commits into from
Jul 15, 2025

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Feb 11, 2025

What does this PR do?

General improvements to the current SSI injector bootstrap implementation

Motivation:

Some things are not quite covered.

Change log entry

Rework SSI from the ground up.

Additional Notes:

How to test the change?

It's a bit hard right now, either we have small granularity CI but a lot of environmental invasion (rspec) or we have isolation but coarse granularity (vaccine). Working on it.

Copy link

github-actions bot commented Feb 11, 2025

👋 Hey @lloeki, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-07-16 12:11:55 UTC

@github-actions github-actions bot added the single-step Single Step APM Instrumentation label Feb 11, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 11, 2025

Datadog Report

Branch report: lloeki/ssi
Commit report: 481cf7f
Test service: dd-trace-rb

✅ 0 Failed, 21765 Passed, 1296 Skipped, 4m 38.86s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (e3a154b) to head (26ed8db).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4366      +/-   ##
==========================================
- Coverage   97.55%   97.54%   -0.01%     
==========================================
  Files        1484     1484              
  Lines       88730    88729       -1     
  Branches     4606     4606              
==========================================
- Hits        86558    86553       -5     
- Misses       2172     2176       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025

Benchmarks

Benchmark execution time: 2025-07-11 14:22:57

Comparing candidate commit 26ed8db in PR branch lloeki/ssi with baseline commit e3a154b in branch master.

Found 1 performance improvements and 3 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:error - error tracking with http - all

  • 🟥 throughput [-121.749op/s; -114.925op/s] or [-96.667%; -91.248%]

scenario:error - error tracking with http - third_party only

  • 🟥 throughput [-126.272op/s; -122.481op/s] or [-95.700%; -92.826%]

scenario:error - error tracking with http - user code only

  • 🟥 throughput [-126.852op/s; -122.555op/s] or [-95.870%; -92.622%]

scenario:profiling - intern_all 1000 repeated strings

  • 🟩 throughput [+1165.159op/s; +1238.783op/s] or [+5.081%; +5.402%]

@lloeki lloeki force-pushed the lloeki/ssi branch 5 times, most recently from e7b84d1 to 4667b63 Compare February 19, 2025 10:54
@lloeki lloeki force-pushed the lloeki/ssi branch 7 times, most recently from 392b10a to bb5d652 Compare June 18, 2025 14:38
@TonyCTHsu TonyCTHsu self-requested a review June 24, 2025 07:55
@lloeki lloeki force-pushed the lloeki/ssi branch 8 times, most recently from 4cd7f82 to 481cf7f Compare June 29, 2025 16:48
@lloeki lloeki force-pushed the lloeki/ssi branch 5 times, most recently from 2aeecb0 to 6a19a14 Compare July 4, 2025 09:28
@lloeki lloeki force-pushed the lloeki/ssi branch 2 times, most recently from 21b3873 to fe35257 Compare July 9, 2025 17:45
@lloeki lloeki marked this pull request as ready for review July 9, 2025 19:44
@lloeki lloeki requested review from a team as code owners July 9, 2025 19:44
@TonyCTHsu TonyCTHsu merged commit 6f46c22 into master Jul 15, 2025
636 of 638 checks passed
@TonyCTHsu TonyCTHsu deleted the lloeki/ssi branch July 15, 2025 18:36
@github-actions github-actions bot added this to the 2.19.0 milestone Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
single-step Single Step APM Instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants