-
Notifications
You must be signed in to change notification settings - Fork 395
Improve SSI #4366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SSI #4366
Conversation
👋 Hey @lloeki, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md (possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None. (possible answers No/Nope/None) Visited at: 2025-07-16 12:11:55 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 21765 Passed, 1296 Skipped, 4m 38.86s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4366 +/- ##
==========================================
- Coverage 97.55% 97.54% -0.01%
==========================================
Files 1484 1484
Lines 88730 88729 -1
Branches 4606 4606
==========================================
- Hits 86558 86553 -5
- Misses 2172 2176 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-07-11 14:22:57 Comparing candidate commit 26ed8db in PR branch Found 1 performance improvements and 3 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:error - error tracking with http - all
scenario:error - error tracking with http - third_party only
scenario:error - error tracking with http - user code only
scenario:profiling - intern_all 1000 repeated strings
|
e7b84d1
to
4667b63
Compare
392b10a
to
bb5d652
Compare
4cd7f82
to
481cf7f
Compare
2aeecb0
to
6a19a14
Compare
21b3873
to
fe35257
Compare
Ruby 2.6 showed up a lot in telemetry.
What does this PR do?
General improvements to the current SSI injector bootstrap implementation
Motivation:
Some things are not quite covered.
Change log entry
Rework SSI from the ground up.
Additional Notes:
How to test the change?
It's a bit hard right now, either we have small granularity CI but a lot of environmental invasion (rspec) or we have isolation but coarse granularity (vaccine). Working on it.