-
Notifications
You must be signed in to change notification settings - Fork 455
chore(benchmarks): add --artifacts and --configs options to perf-run-scenario #14406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…scenario The goal is to allow people to select which benchmark configs they want to run, this allows people to skip unrelated/unnecessary configs if they want to iterate quickly locally. Since we added --configs, moved artifacts to --artifacts as well, keeping the other positional arguments for now
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 272 ± 4 ms. The average import time from base is: 279 ± 5 ms. The import time difference between this PR and base is: -6.1 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: brettlangdon/perf.run.configs (ccf581a) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
The goal is to allow people to select which benchmark configs they want to run, this allows people to skip unrelated/unnecessary configs if they want to iterate quickly locally.
Since we added --configs, moved artifacts to --artifacts as well, keeping the other positional arguments for now
Checklist
Reviewer Checklist