-
Notifications
You must be signed in to change notification settings - Fork 457
chore(rc): APM_TRACING_MULTICONFIG support #14364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 272 ± 4 ms. The average import time from base is: 273 ± 4 ms. The import time difference between this PR and base is: -1.4 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: chore/apm-tracing-multiconfig (23762a7) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
self.config_map.pop(config_id, None) | ||
|
||
if lib_config := self.get_chained_lib_config(): | ||
dispatch("apm-tracing.rc", (lib_config, config)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't trigger a callback if the last config was removed. right?
We add support for the multiconfig overrides in APM_TRACING RC payloads.
c00641c
to
23762a7
Compare
We add support for the multiconfig overrides in APM_TRACING RC payloads.
Checklist
Reviewer Checklist