Skip to content

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Jul 2, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux added ASM Application Security Monitoring CI labels Jul 2, 2025
Copy link
Contributor

github-actions bot commented Jul 2, 2025

CODEOWNERS have been resolved as:

.riot/requirements/10a053e.txt                                          @DataDog/apm-python
.riot/requirements/14f9b26.txt                                          @DataDog/apm-python
.riot/requirements/168930f.txt                                          @DataDog/apm-python
.riot/requirements/182ca07.txt                                          @DataDog/apm-python
.riot/requirements/199cda7.txt                                          @DataDog/apm-python
.riot/requirements/1b06f43.txt                                          @DataDog/apm-python
.riot/requirements/1cb891d.txt                                          @DataDog/apm-python
.riot/requirements/1d71a4a.txt                                          @DataDog/apm-python
.riot/requirements/1e5d795.txt                                          @DataDog/apm-python
.riot/requirements/1eebb20.txt                                          @DataDog/apm-python
.riot/requirements/4727e92.txt                                          @DataDog/apm-python
.riot/requirements/49711bf.txt                                          @DataDog/apm-python
.riot/requirements/5cef490.txt                                          @DataDog/apm-python
.riot/requirements/7b8bfb0.txt                                          @DataDog/apm-python
.riot/requirements/9ff1a39.txt                                          @DataDog/apm-python
.riot/requirements/a74d86f.txt                                          @DataDog/apm-python
.riot/requirements/aa30c9e.txt                                          @DataDog/apm-python
.riot/requirements/b7ac57f.txt                                          @DataDog/apm-python
.riot/requirements/c00aefc.txt                                          @DataDog/apm-python
.riot/requirements/f8fcf35.txt                                          @DataDog/apm-python
hatch.toml                                                              @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
tests/appsec/suitespec.yml                                              @DataDog/asm-python

Copy link
Contributor

github-actions bot commented Jul 2, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 278 ± 3 ms.

The average import time from base is: 281 ± 4 ms.

The import time difference between this PR and base is: -2.8 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.047 ms (0.73%)
ddtrace.bootstrap.sitecustomize 1.373 ms (0.49%)
ddtrace.bootstrap.preload 1.373 ms (0.49%)
ddtrace.internal.remoteconfig.client 0.676 ms (0.24%)
ddtrace 0.674 ms (0.24%)
ddtrace.internal._unpatched 0.030 ms (0.01%)
json 0.030 ms (0.01%)
json.decoder 0.030 ms (0.01%)
re 0.030 ms (0.01%)
enum 0.030 ms (0.01%)
types 0.030 ms (0.01%)

@juanjux juanjux self-assigned this Jul 2, 2025
@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. and removed backport 2.21 labels Jul 2, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jul 2, 2025

Benchmarks

Benchmark execution time: 2025-07-09 15:23:21

Comparing candidate commit fb66870 in PR branch juanjux/riotize-threats-flask with baseline commit 573a530 in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 542 metrics, 4 unstable metrics.

scenario:iastaspects-replace_aspect

  • 🟥 execution_time [+619.561ns; +729.264ns] or [+13.025%; +15.331%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+704.657ns; +828.588ns] or [+16.484%; +19.383%]

scenario:iastaspectsospath-ospathjoin_aspect

  • 🟥 execution_time [+954.265ns; +1039.627ns] or [+15.538%; +16.928%]

scenario:telemetryaddmetric-1-gauge-metric-1-times

  • 🟥 execution_time [+148.134ns; +192.478ns] or [+7.063%; +9.177%]

@juanjux juanjux marked this pull request as ready for review July 2, 2025 15:49
@juanjux juanjux requested review from a team as code owners July 2, 2025 15:49
Copy link
Collaborator

@emmettbutler emmettbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed with brett's comment, otherwise looks good

juanjux and others added 2 commits July 7, 2025 15:53
Co-authored-by: Brett Langdon <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux requested a review from brettlangdon July 7, 2025 14:05
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we missing a change to remove from hatch ?

@juanjux juanjux requested a review from a team as a code owner July 8, 2025 22:37
Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux
Copy link
Collaborator Author

juanjux commented Jul 8, 2025

are we missing a change to remove from hatch ?

Fixed, thanks.

@juanjux juanjux enabled auto-merge (squash) July 9, 2025 10:11
@juanjux juanjux disabled auto-merge July 9, 2025 14:19
@juanjux juanjux closed this Jul 9, 2025
@juanjux juanjux reopened this Jul 9, 2025
@juanjux juanjux enabled auto-merge (squash) July 9, 2025 14:55
@juanjux juanjux merged commit a8be009 into main Jul 9, 2025
866 of 867 checks passed
@juanjux juanjux deleted the juanjux/riotize-threats-flask branch July 9, 2025 15:28
alyshawang pushed a commit that referenced this pull request Jul 25, 2025
## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Signed-off-by: Juanjo Alvarez <[email protected]>
Co-authored-by: Brett Langdon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants