-
Notifications
You must be signed in to change notification settings - Fork 455
chore(ci): riotize appsec_threats_flask #13858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Juanjo Alvarez <[email protected]>
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 278 ± 3 ms. The average import time from base is: 281 ± 4 ms. The import time difference between this PR and base is: -2.8 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Signed-off-by: Juanjo Alvarez <[email protected]>
BenchmarksBenchmark execution time: 2025-07-09 15:23:21 Comparing candidate commit fb66870 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 542 metrics, 4 unstable metrics. scenario:iastaspects-replace_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:iastaspectsospath-ospathjoin_aspect
scenario:telemetryaddmetric-1-gauge-metric-1-times
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed with brett's comment, otherwise looks good
Co-authored-by: Brett Langdon <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we missing a change to remove from hatch ?
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Fixed, thanks. |
Signed-off-by: Juanjo Alvarez <[email protected]>
…taDog/dd-trace-py into juanjux/riotize-threats-flask
…ts-flask # Conflicts: # hatch.toml # riotfile.py
## Checklist - [X] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Signed-off-by: Juanjo Alvarez <[email protected]> Co-authored-by: Brett Langdon <[email protected]>
Checklist
Reviewer Checklist