fix: generator wrapping with Python 3.10 [backport 3.9] #13841
Merged
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
Dynamic Instrumentation
github-actions
bot
requested review from
Kyle-Verhoog,
ZStriker19 and
brettlangdon
P403n1x87
approved these changes
Jul 1, 2025
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 278 ± 4 ms. The average import time from base is: 281 ± 4 ms. The import time difference between this PR and base is: -2.6 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-07-03 14:19:11 Comparing candidate commit 1a75d0a in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 556 metrics, 5 unstable metrics. scenario:iastdjangostartup-appsec
|
emmettbutler
approved these changes
Jul 1, 2025
ZStriker19
approved these changes
Jul 1, 2025
brettlangdon
force-pushed
the
backport-13835-to-3.9
branch
from
9472e87 to
3ee203a
Compare
We fix an issue with generator wrapping with Python 3.10 that could have caused an exception to be raised after the generator had been used and exhausted. The issue has been caught by the exploration tests. - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
brettlangdon
force-pushed
the
backport-13835-to-3.9
branch
from
3ee203a to
1a75d0a
Compare
brettlangdon
removed request for
a team,
anmarchenko,
Kyle-Verhoog and
rachelyangdog
brettlangdon
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5d10180 from #13835 to 3.9.
We fix an issue with generator wrapping with Python 3.10 that could have caused an exception to be raised after the generator had been used and exhausted.
Testing Strategy
The issue has been caught by the exploration tests.
Checklist
Reviewer Checklist