Skip to content

fix: generator wrapping with Python 3.10 [backport 2.21] #13840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.21
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 1, 2025

Backport 5d10180 from #13835 to 2.21.

We fix an issue with generator wrapping with Python 3.10 that could have caused an exception to be raised after the generator had been used and exhausted.

Testing Strategy

The issue has been caught by the exploration tests.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We fix an issue with generator wrapping with Python 3.10 that could have
caused an exception to be raised after the generator had been used and
exhausted.

## Testing Strategy

The issue has been caught by the exploration tests.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 5d10180)
@github-actions github-actions bot added the Dynamic Instrumentation Dynamic Instrumentation/Live Debugger label Jul 1, 2025
@github-actions github-actions bot requested review from a team as code owners July 1, 2025 13:44
@github-actions github-actions bot added the Dynamic Instrumentation Dynamic Instrumentation/Live Debugger label Jul 1, 2025
@github-actions github-actions bot requested review from emmettbutler and nsrip-dd July 1, 2025 13:44
@P403n1x87 P403n1x87 closed this Jul 1, 2025
@P403n1x87 P403n1x87 reopened this Jul 1, 2025
@P403n1x87 P403n1x87 enabled auto-merge (squash) July 1, 2025 13:46
Copy link
Contributor Author

github-actions bot commented Jul 1, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/fix-generator-wrapping-86af0ae55ba2723a.yaml         @DataDog/apm-python
ddtrace/internal/wrapping/context.py                                    @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Jul 1, 2025

Benchmarks

Benchmark execution time: 2025-07-01 14:26:42

Comparing candidate commit b13a8ea in PR branch backport-13835-to-2.21 with baseline commit 7990c03 in branch 2.21.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 226 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants