-
Notifications
You must be signed in to change notification settings - Fork 455
chore(azure_servicebus): use azure.servicebus.send for operation #13829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(azure_servicebus): use azure.servicebus.send for operation #13829
Conversation
…ion schema for v1 operation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 276 ± 3 ms. The average import time from base is: 277 ± 3 ms. The import time difference between this PR and base is: -1.0 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-07-01 16:39:25 Comparing candidate commit 853c039 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 570 metrics, 2 unstable metrics. |
releasenotes/notes/fix-azure-servicebus-operation-15b719141c6c89ee.yaml
Outdated
Show resolved
Hide resolved
) In #13691 the v0 messaging operation for azure_servicebus was set to `azure.servicebus.produce` to follow the pattern set by the kafka integration (`kafka.produce`). However since the v1 operation schema is `*.send` both in this tracer and other tracers, and this is a new integration, we should use this `*.send` schema from the start. - use `azure.servicebus.send` for v0 operation - use cloud messaging operation schema for v1 operation **Note that PR #13691 has not been released yet so this is not considered a breaking change and no release note is needed** ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
) In #13691 the v0 messaging operation for azure_servicebus was set to `azure.servicebus.produce` to follow the pattern set by the kafka integration (`kafka.produce`). However since the v1 operation schema is `*.send` both in this tracer and other tracers, and this is a new integration, we should use this `*.send` schema from the start. - use `azure.servicebus.send` for v0 operation - use cloud messaging operation schema for v1 operation **Note that PR #13691 has not been released yet so this is not considered a breaking change and no release note is needed** ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
In #13691 the v0 messaging operation for azure_servicebus was set to
azure.servicebus.produce
to follow the pattern set by the kafka integration (kafka.produce
). However since the v1 operation schema is*.send
both in this tracer and other tracers, and this is a new integration, we should use this*.send
schema from the start.azure.servicebus.send
for v0 operationNote that PR #13691 has not been released yet so this is not considered a breaking change and no release note is needed
Checklist
Reviewer Checklist