Skip to content

test: fix testing warnings #13827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2025
Merged

test: fix testing warnings #13827

merged 5 commits into from
Jul 3, 2025

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Jun 30, 2025

Internal clone of #13442

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested review from a team as code owners June 30, 2025 17:36
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/psycopg/test_psycopg_async.py                             @DataDog/apm-core-python @DataDog/apm-idm-python

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 30, 2025
Copy link
Contributor

github-actions bot commented Jun 30, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 277 ± 4 ms.

The average import time from base is: 280 ± 4 ms.

The import time difference between this PR and base is: -3.9 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.119 ms (0.77%)
ddtrace.bootstrap.sitecustomize 1.440 ms (0.52%)
ddtrace.bootstrap.preload 1.440 ms (0.52%)
ddtrace.internal.remoteconfig.client 0.689 ms (0.25%)
ddtrace 0.678 ms (0.25%)
ddtrace.internal._unpatched 0.032 ms (0.01%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 30, 2025

Benchmarks

Benchmark execution time: 2025-07-03 17:57:33

Comparing candidate commit 12d70dc in PR branch emmanuel-ferdman-main with baseline commit 7b1d839 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 523 metrics, 2 unstable metrics.

scenario:iastaspects-replace_aspect

  • 🟥 execution_time [+676.210ns; +746.659ns] or [+14.218%; +15.700%]

@brettlangdon brettlangdon enabled auto-merge (squash) July 3, 2025 13:30
@brettlangdon brettlangdon merged commit fa95114 into main Jul 3, 2025
403 checks passed
@brettlangdon brettlangdon deleted the emmanuel-ferdman-main branch July 3, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants