-
Notifications
You must be signed in to change notification settings - Fork 443
fix: iteration block hook injection [backport 3.9] #13802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 275 ± 3 ms. The average import time from base is: 276 ± 2 ms. The import time difference between this PR and base is: -1.7 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-30 14:09:03 Comparing candidate commit d883fbb in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 528 metrics, 2 unstable metrics. scenario:iastaspects-format_map_aspect
scenario:iastaspectsospath-ospathsplitdrive_aspect
|
c0cc765
to
d883fbb
Compare
Pull request was closed
Backport d7b62d5 from #13772 to 3.9.
We fix an issue with the instrumentation of the beginning of iteration blocks (e.g. for loops) whereby instrumenting the end might cause unexpected behaviour when the modified function is invoked. This is due to the bytecode VM not liking any bytecode interposed before the instruction that ends the iteration block (e.g.
END_FOR
). This also solves the problem of double-calls of the instrumented hook when hitting the beginning of such blocks.Checklist
Reviewer Checklist