Skip to content

ci: move DI exploration tests to GitLab #13783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Jun 26, 2025

We extract the exploration tests from the rest of the framework tests and move them to GitLab. We also pick some different frameworks as well. To begin with, we start with boto3, which at the time of opening this PR is the most downloaded package from PyPI. We also introduce a matrix to ensure that we test the same framework with all the supported versions of Python.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Jun 26, 2025
Copy link
Contributor

github-actions bot commented Jun 26, 2025

CODEOWNERS have been resolved as:

.gitlab/templates/debugging/exploration.yml                             @DataDog/python-guild @DataDog/apm-core-python
tests/debugging/exploration/pytest/exploration.py                       @DataDog/debugger-python
.github/workflows/test_frameworks.yml                                   @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python
scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python
tests/debugging/exploration/_config.py                                  @DataDog/debugger-python
tests/debugging/exploration/_coverage.py                                @DataDog/debugger-python
tests/debugging/exploration/_profiler.py                                @DataDog/debugger-python
tests/debugging/exploration/debugger.py                                 @DataDog/debugger-python
tests/debugging/exploration/test_bootstrap.py                           @DataDog/debugger-python
tests/debugging/exploration/utils.py                                    @DataDog/debugger-python

@P403n1x87 P403n1x87 force-pushed the ci/extract-di-exploration-tests branch from 7e53e44 to 1b0c445 Compare June 26, 2025 10:37
Copy link
Contributor

github-actions bot commented Jun 26, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 279 ± 6 ms.

The average import time from base is: 285 ± 9 ms.

The import time difference between this PR and base is: -6.2 ± 0.3 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.784 ms (1.00%)
ddtrace.bootstrap.sitecustomize 1.752 ms (0.63%)
ddtrace.bootstrap.preload 1.752 ms (0.63%)
ddtrace.internal.remoteconfig.client 0.712 ms (0.26%)
ddtrace 1.032 ms (0.37%)
ddtrace._logger 0.326 ms (0.12%)
ddtrace.internal.telemetry 0.326 ms (0.12%)
ddtrace.internal.telemetry.writer 0.326 ms (0.12%)
http.client 0.191 ms (0.07%)
ssl 0.191 ms (0.07%)
_ssl 0.191 ms (0.07%)
ddtrace.internal.periodic 0.135 ms (0.05%)
ddtrace.internal._threads 0.135 ms (0.05%)
ddtrace.internal._unpatched 0.036 ms (0.01%)
json 0.036 ms (0.01%)
json.decoder 0.036 ms (0.01%)
re 0.036 ms (0.01%)
enum 0.036 ms (0.01%)
types 0.036 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 26, 2025

Benchmarks

Benchmark execution time: 2025-06-30 16:36:27

Comparing candidate commit 8939ef4 in PR branch ci/extract-di-exploration-tests with baseline commit 563f14b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 553 metrics, 3 unstable metrics.

@P403n1x87 P403n1x87 force-pushed the ci/extract-di-exploration-tests branch 9 times, most recently from 176b574 to 256fb17 Compare June 27, 2025 22:17
@P403n1x87 P403n1x87 force-pushed the ci/extract-di-exploration-tests branch 3 times, most recently from 901d1e6 to 1aeee31 Compare June 30, 2025 09:47
We extract the exploration tests from the rest of the framework tests
and move them to GitLab.
@P403n1x87 P403n1x87 force-pushed the ci/extract-di-exploration-tests branch from 1aeee31 to 28d0fe2 Compare June 30, 2025 11:19
@P403n1x87 P403n1x87 force-pushed the ci/extract-di-exploration-tests branch 3 times, most recently from 0256e91 to 9969e99 Compare June 30, 2025 14:20
We extract the exploration tests from the rest of the framework tests
and move them to GitLab.
@P403n1x87 P403n1x87 force-pushed the ci/extract-di-exploration-tests branch from 9969e99 to 66ba16f Compare June 30, 2025 14:32
@P403n1x87 P403n1x87 marked this pull request as ready for review June 30, 2025 14:38
@P403n1x87 P403n1x87 requested a review from a team as a code owner June 30, 2025 14:38
@P403n1x87 P403n1x87 requested review from a team as code owners June 30, 2025 14:38
@P403n1x87 P403n1x87 requested review from RamyElkest and juanjux June 30, 2025 14:38
@P403n1x87 P403n1x87 enabled auto-merge (squash) June 30, 2025 14:39
@P403n1x87 P403n1x87 force-pushed the ci/extract-di-exploration-tests branch from a0879ec to 8939ef4 Compare June 30, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant