Skip to content

Conversation

estringana
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.85%. Comparing base (adcd254) to head (e74fea9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3381      +/-   ##
==========================================
+ Coverage   61.73%   61.85%   +0.12%     
==========================================
  Files         141      141              
  Lines       12481    12481              
  Branches     1630     1630              
==========================================
+ Hits         7705     7720      +15     
+ Misses       4055     4041      -14     
+ Partials      721      720       -1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adcd254...e74fea9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Aug 25, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-08-27 10:09:49

Comparing candidate commit 96601ba in PR branch estringana/collect-framework-endpoints with baseline commit a98d2b7 in branch master.

Found 0 performance improvements and 7 performance regressions! Performance is the same for 170 metrics, 1 unstable metrics.

scenario:ContextPropagationBench/benchInject64Bit

  • 🟥 execution_time [+668.008ns; +905.992ns] or [+8.831%; +11.978%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+8.818µs; +9.702µs] or [+8.420%; +9.263%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+2.378µs; +3.802µs] or [+2.156%; +3.449%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+741.281ns; +975.519ns] or [+11.005%; +14.482%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+678.354ns; +923.246ns] or [+9.989%; +13.595%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+661.828ns; +914.772ns] or [+9.670%; +13.366%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+581.380ns; +797.420ns] or [+8.527%; +11.696%]

@estringana estringana force-pushed the estringana/collect-framework-endpoints branch from 96601ba to 791f8e7 Compare August 27, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants