-
Notifications
You must be signed in to change notification settings - Fork 305
Improve rum injection output stream #9107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amarziali
wants to merge
2
commits into
project/rum-injection
Choose a base branch
from
andrea.marziali/better-piped-injector
base: project/rum-injection
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve rum injection output stream #9107
amarziali
wants to merge
2
commits into
project/rum-injection
from
andrea.marziali/better-piped-injector
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~5c742205b7, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.356 ms) : 0, 996356
Total [baseline] (8.555 s) : 0, 8554883
Agent [candidate] (993.296 ms) : 0, 993296
Total [candidate] (8.589 s) : 0, 8589257
section iast
Agent [baseline] (1.135 s) : 0, 1134849
Total [baseline] (9.277 s) : 0, 9276861
Agent [candidate] (1.135 s) : 0, 1134998
Total [candidate] (9.284 s) : 0, 9283706
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~5c742205b7, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.71 ms) : 0, 687710
BytebuddyAgent [candidate] (685.95 ms) : 0, 685950
GlobalTracer [baseline] (242.05 ms) : 0, 242050
GlobalTracer [candidate] (241.686 ms) : 0, 241686
AppSec [baseline] (30.216 ms) : 0, 30216
AppSec [candidate] (30.12 ms) : 0, 30120
Debugger [baseline] (6.086 ms) : 0, 6086
Debugger [candidate] (6.08 ms) : 0, 6080
Remote Config [baseline] (686.145 µs) : 0, 686
Remote Config [candidate] (676.06 µs) : 0, 676
Telemetry [baseline] (8.213 ms) : 0, 8213
Telemetry [candidate] (8.228 ms) : 0, 8228
section iast
BytebuddyAgent [baseline] (809.044 ms) : 0, 809044
BytebuddyAgent [candidate] (808.629 ms) : 0, 808629
GlobalTracer [baseline] (233.316 ms) : 0, 233316
GlobalTracer [candidate] (233.549 ms) : 0, 233549
AppSec [baseline] (29.063 ms) : 0, 29063
AppSec [candidate] (29.671 ms) : 0, 29671
Debugger [baseline] (6.606 ms) : 0, 6606
Debugger [candidate] (5.826 ms) : 0, 5826
Remote Config [baseline] (573.924 µs) : 0, 574
Remote Config [candidate] (583.913 µs) : 0, 584
Telemetry [baseline] (8.006 ms) : 0, 8006
Telemetry [candidate] (8.068 ms) : 0, 8068
IAST [baseline] (26.811 ms) : 0, 26811
IAST [candidate] (27.921 ms) : 0, 27921
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~5c742205b7, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (995.65 ms) : 0, 995650
Total [baseline] (10.584 s) : 0, 10584314
Agent [candidate] (995.84 ms) : 0, 995840
Total [candidate] (10.64 s) : 0, 10639774
section appsec
Agent [baseline] (1.173 s) : 0, 1173142
Total [baseline] (10.71 s) : 0, 10709890
Agent [candidate] (1.177 s) : 0, 1176607
Total [candidate] (10.778 s) : 0, 10778444
section iast
Agent [baseline] (1.135 s) : 0, 1134757
Total [baseline] (10.83 s) : 0, 10830373
Agent [candidate] (1.136 s) : 0, 1136174
Total [candidate] (10.824 s) : 0, 10823581
section profiling
Agent [baseline] (1.246 s) : 0, 1246298
Total [baseline] (11.001 s) : 0, 11000536
Agent [candidate] (1.242 s) : 0, 1242372
Total [candidate] (10.972 s) : 0, 10971505
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~5c742205b7, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.358 ms) : 0, 687358
BytebuddyAgent [candidate] (687.926 ms) : 0, 687926
GlobalTracer [baseline] (241.923 ms) : 0, 241923
GlobalTracer [candidate] (242.293 ms) : 0, 242293
AppSec [baseline] (30.114 ms) : 0, 30114
AppSec [candidate] (29.988 ms) : 0, 29988
Debugger [baseline] (6.0 ms) : 0, 6000
Debugger [candidate] (6.038 ms) : 0, 6038
Remote Config [baseline] (680.064 µs) : 0, 680
Remote Config [candidate] (674.268 µs) : 0, 674
Telemetry [baseline] (8.226 ms) : 0, 8226
Telemetry [candidate] (8.177 ms) : 0, 8177
section appsec
BytebuddyAgent [baseline] (708.982 ms) : 0, 708982
BytebuddyAgent [candidate] (710.637 ms) : 0, 710637
GlobalTracer [baseline] (234.837 ms) : 0, 234837
GlobalTracer [candidate] (235.202 ms) : 0, 235202
IAST [baseline] (22.932 ms) : 0, 22932
IAST [candidate] (23.157 ms) : 0, 23157
AppSec [baseline] (170.639 ms) : 0, 170639
AppSec [candidate] (172.23 ms) : 0, 172230
Debugger [baseline] (5.729 ms) : 0, 5729
Debugger [candidate] (5.81 ms) : 0, 5810
Remote Config [baseline] (603.155 µs) : 0, 603
Remote Config [candidate] (609.938 µs) : 0, 610
Telemetry [baseline] (8.038 ms) : 0, 8038
Telemetry [candidate] (8.185 ms) : 0, 8185
section iast
BytebuddyAgent [baseline] (808.081 ms) : 0, 808081
BytebuddyAgent [candidate] (809.96 ms) : 0, 809960
GlobalTracer [baseline] (233.263 ms) : 0, 233263
GlobalTracer [candidate] (233.535 ms) : 0, 233535
IAST [baseline] (26.249 ms) : 0, 26249
IAST [candidate] (29.439 ms) : 0, 29439
AppSec [baseline] (31.208 ms) : 0, 31208
AppSec [candidate] (27.848 ms) : 0, 27848
Debugger [baseline] (5.883 ms) : 0, 5883
Debugger [candidate] (5.883 ms) : 0, 5883
Remote Config [baseline] (587.034 µs) : 0, 587
Remote Config [candidate] (584.895 µs) : 0, 585
Telemetry [baseline] (8.019 ms) : 0, 8019
Telemetry [candidate] (8.084 ms) : 0, 8084
section profiling
BytebuddyAgent [baseline] (678.99 ms) : 0, 678990
BytebuddyAgent [candidate] (677.004 ms) : 0, 677004
GlobalTracer [baseline] (361.656 ms) : 0, 361656
GlobalTracer [candidate] (360.886 ms) : 0, 360886
AppSec [baseline] (32.41 ms) : 0, 32410
AppSec [candidate] (31.614 ms) : 0, 31614
Debugger [baseline] (10.678 ms) : 0, 10678
Debugger [candidate] (12.024 ms) : 0, 12024
Remote Config [baseline] (663.833 µs) : 0, 664
Remote Config [candidate] (660.237 µs) : 0, 660
Telemetry [baseline] (9.495 ms) : 0, 9495
Telemetry [candidate] (8.732 ms) : 0, 8732
ProfilingAgent [baseline] (103.327 ms) : 0, 103327
ProfilingAgent [candidate] (102.967 ms) : 0, 102967
Profiling [baseline] (103.351 ms) : 0, 103351
Profiling [candidate] (102.991 ms) : 0, 102991
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~5c742205b7, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (4.369 ms) : 4316, 4422
. : milestone, 4369,
iast (9.344 ms) : 9189, 9500
. : milestone, 9344,
iast_FULL (13.943 ms) : 13665, 14222
. : milestone, 13943,
iast_GLOBAL (10.03 ms) : 9848, 10211
. : milestone, 10030,
profiling (8.593 ms) : 8452, 8733
. : milestone, 8593,
tracing (7.63 ms) : 7513, 7746
. : milestone, 7630,
section candidate
no_agent (4.368 ms) : 4307, 4428
. : milestone, 4368,
iast (9.231 ms) : 9073, 9388
. : milestone, 9231,
iast_FULL (13.717 ms) : 13446, 13988
. : milestone, 13717,
iast_GLOBAL (10.293 ms) : 10116, 10471
. : milestone, 10293,
profiling (8.759 ms) : 8625, 8893
. : milestone, 8759,
tracing (7.909 ms) : 7796, 8023
. : milestone, 7909,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~5c742205b7, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (38.094 ms) : 37780, 38408
. : milestone, 38094,
appsec (48.144 ms) : 47701, 48588
. : milestone, 48144,
code_origins (44.272 ms) : 43896, 44648
. : milestone, 44272,
iast (44.983 ms) : 44586, 45379
. : milestone, 44983,
profiling (48.476 ms) : 48026, 48925
. : milestone, 48476,
tracing (44.301 ms) : 43933, 44669
. : milestone, 44301,
section candidate
no_agent (37.854 ms) : 37551, 38157
. : milestone, 37854,
appsec (45.15 ms) : 44756, 45545
. : milestone, 45150,
code_origins (45.542 ms) : 45142, 45943
. : milestone, 45542,
iast (44.484 ms) : 44112, 44856
. : milestone, 44484,
profiling (47.968 ms) : 47527, 48408
. : milestone, 47968,
tracing (44.43 ms) : 44055, 44805
. : milestone, 44430,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~5c742205b7, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.409 ms) : 2359, 2458
. : milestone, 2409,
iast (2.206 ms) : 2143, 2269
. : milestone, 2206,
iast_GLOBAL (2.237 ms) : 2175, 2300
. : milestone, 2237,
profiling (2.511 ms) : 2333, 2690
. : milestone, 2511,
tracing (2.007 ms) : 1959, 2055
. : milestone, 2007,
section candidate
no_agent (1.479 ms) : 1467, 1491
. : milestone, 1479,
appsec (2.409 ms) : 2359, 2458
. : milestone, 2409,
iast (2.194 ms) : 2131, 2257
. : milestone, 2194,
iast_GLOBAL (2.25 ms) : 2187, 2313
. : milestone, 2250,
profiling (2.055 ms) : 2004, 2107
. : milestone, 2055,
tracing (2.01 ms) : 1962, 2059
. : milestone, 2010,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~5c742205b7, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
appsec (14.835 s) : 14835000, 14835000
. : milestone, 14835000,
iast (18.499 s) : 18499000, 18499000
. : milestone, 18499000,
iast_GLOBAL (18.014 s) : 18014000, 18014000
. : milestone, 18014000,
profiling (15.901 s) : 15901000, 15901000
. : milestone, 15901000,
tracing (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
section candidate
no_agent (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
appsec (14.873 s) : 14873000, 14873000
. : milestone, 14873000,
iast (18.283 s) : 18283000, 18283000
. : milestone, 18283000,
iast_GLOBAL (17.682 s) : 17682000, 17682000
. : milestone, 17682000,
profiling (15.322 s) : 15322000, 15322000
. : milestone, 15322000,
tracing (14.794 s) : 14794000, 14794000
. : milestone, 14794000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Implement bulk write (FilteredOutputStream does not hence looping on each byte).
Also did some bench. JMH shows one increment of 30% to write a google home page while looking for
</head>
and injecting a content. However this can be justified since this feature is obviously introducing an impact (It's not enabled by default).On the other hand, the algorithm can maybe be optimized but I'm lacking of ideas today
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]