chore(build): Skip empty parent instrumentation projects #9106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bric3
added
tag: no release notes
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~ac9151dc73, baseline=1.51.0-SNAPSHOT~041214be86
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (995.294 ms) : 0, 995294
Total [baseline] (8.631 s) : 0, 8630876
Agent [candidate] (994.905 ms) : 0, 994905
Total [candidate] (8.574 s) : 0, 8573632
section iast
Agent [baseline] (1.145 s) : 0, 1145045
Total [baseline] (9.288 s) : 0, 9288290
Agent [candidate] (1.132 s) : 0, 1131884
Total [candidate] (9.271 s) : 0, 9270929
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~ac9151dc73, baseline=1.51.0-SNAPSHOT~041214be86
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.7 ms) : 0, 686700
BytebuddyAgent [candidate] (686.531 ms) : 0, 686531
GlobalTracer [baseline] (242.615 ms) : 0, 242615
GlobalTracer [candidate] (242.386 ms) : 0, 242386
AppSec [baseline] (30.201 ms) : 0, 30201
AppSec [candidate] (30.26 ms) : 0, 30260
Debugger [baseline] (6.054 ms) : 0, 6054
Debugger [candidate] (6.043 ms) : 0, 6043
Remote Config [baseline] (678.441 µs) : 0, 678
Remote Config [candidate] (673.054 µs) : 0, 673
Telemetry [baseline] (8.218 ms) : 0, 8218
Telemetry [candidate] (8.24 ms) : 0, 8240
section iast
BytebuddyAgent [baseline] (816.463 ms) : 0, 816463
BytebuddyAgent [candidate] (807.527 ms) : 0, 807527
GlobalTracer [baseline] (235.313 ms) : 0, 235313
GlobalTracer [candidate] (232.079 ms) : 0, 232079
AppSec [baseline] (30.376 ms) : 0, 30376
AppSec [candidate] (29.623 ms) : 0, 29623
Debugger [baseline] (5.93 ms) : 0, 5930
Debugger [candidate] (5.78 ms) : 0, 5780
Remote Config [baseline] (597.897 µs) : 0, 598
Remote Config [candidate] (577.445 µs) : 0, 577
Telemetry [baseline] (8.11 ms) : 0, 8110
Telemetry [candidate] (7.865 ms) : 0, 7865
IAST [baseline] (26.462 ms) : 0, 26462
IAST [candidate] (27.714 ms) : 0, 27714
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~ac9151dc73, baseline=1.51.0-SNAPSHOT~041214be86
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.034 ms) : 0, 996034
Total [baseline] (10.637 s) : 0, 10637148
Agent [candidate] (994.68 ms) : 0, 994680
Total [candidate] (10.759 s) : 0, 10758977
section appsec
Agent [baseline] (1.188 s) : 0, 1188022
Total [baseline] (10.807 s) : 0, 10807417
Agent [candidate] (1.175 s) : 0, 1174948
Total [candidate] (10.731 s) : 0, 10731241
section iast
Agent [baseline] (1.134 s) : 0, 1134482
Total [baseline] (10.835 s) : 0, 10835378
Agent [candidate] (1.135 s) : 0, 1135042
Total [candidate] (10.796 s) : 0, 10796070
section profiling
Agent [baseline] (1.243 s) : 0, 1243286
Total [baseline] (11.002 s) : 0, 11002041
Agent [candidate] (1.248 s) : 0, 1247594
Total [candidate] (10.864 s) : 0, 10863924
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~ac9151dc73, baseline=1.51.0-SNAPSHOT~041214be86
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.276 ms) : 0, 687276
BytebuddyAgent [candidate] (686.679 ms) : 0, 686679
GlobalTracer [baseline] (242.725 ms) : 0, 242725
GlobalTracer [candidate] (242.247 ms) : 0, 242247
AppSec [baseline] (30.311 ms) : 0, 30311
AppSec [candidate] (30.104 ms) : 0, 30104
Debugger [baseline] (6.055 ms) : 0, 6055
Debugger [candidate] (5.986 ms) : 0, 5986
Remote Config [baseline] (674.73 µs) : 0, 675
Remote Config [candidate] (675.66 µs) : 0, 676
Telemetry [baseline] (8.22 ms) : 0, 8220
Telemetry [candidate] (8.221 ms) : 0, 8221
section appsec
BytebuddyAgent [baseline] (719.762 ms) : 0, 719762
BytebuddyAgent [candidate] (710.2 ms) : 0, 710200
GlobalTracer [baseline] (237.134 ms) : 0, 237134
GlobalTracer [candidate] (235.232 ms) : 0, 235232
AppSec [baseline] (172.102 ms) : 0, 172102
AppSec [candidate] (170.963 ms) : 0, 170963
Debugger [baseline] (5.789 ms) : 0, 5789
Debugger [candidate] (5.761 ms) : 0, 5761
Remote Config [baseline] (609.238 µs) : 0, 609
Remote Config [candidate] (597.713 µs) : 0, 598
Telemetry [baseline] (8.163 ms) : 0, 8163
Telemetry [candidate] (8.108 ms) : 0, 8108
IAST [baseline] (23.445 ms) : 0, 23445
IAST [candidate] (23.17 ms) : 0, 23170
section iast
BytebuddyAgent [baseline] (808.997 ms) : 0, 808997
BytebuddyAgent [candidate] (809.45 ms) : 0, 809450
GlobalTracer [baseline] (232.852 ms) : 0, 232852
GlobalTracer [candidate] (232.569 ms) : 0, 232569
AppSec [baseline] (26.962 ms) : 0, 26962
AppSec [candidate] (32.326 ms) : 0, 32326
Debugger [baseline] (5.868 ms) : 0, 5868
Debugger [candidate] (5.801 ms) : 0, 5801
Remote Config [baseline] (619.091 µs) : 0, 619
Remote Config [candidate] (581.629 µs) : 0, 582
Telemetry [baseline] (8.032 ms) : 0, 8032
Telemetry [candidate] (7.932 ms) : 0, 7932
IAST [baseline] (30.34 ms) : 0, 30340
IAST [candidate] (25.41 ms) : 0, 25410
section profiling
ProfilingAgent [baseline] (104.172 ms) : 0, 104172
ProfilingAgent [candidate] (103.088 ms) : 0, 103088
BytebuddyAgent [baseline] (676.572 ms) : 0, 676572
BytebuddyAgent [candidate] (680.722 ms) : 0, 680722
GlobalTracer [baseline] (360.969 ms) : 0, 360969
GlobalTracer [candidate] (361.893 ms) : 0, 361893
AppSec [baseline] (32.292 ms) : 0, 32292
AppSec [candidate] (30.843 ms) : 0, 30843
Debugger [baseline] (10.759 ms) : 0, 10759
Debugger [candidate] (12.094 ms) : 0, 12094
Remote Config [baseline] (674.082 µs) : 0, 674
Remote Config [candidate] (655.804 µs) : 0, 656
Telemetry [baseline] (9.431 ms) : 0, 9431
Telemetry [candidate] (9.57 ms) : 0, 9570
Profiling [baseline] (104.196 ms) : 0, 104196
Profiling [candidate] (103.111 ms) : 0, 103111
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~ac9151dc73, baseline=1.51.0-SNAPSHOT~041214be86
dateFormat X
axisFormat %s
section baseline
no_agent (4.46 ms) : 4408, 4513
. : milestone, 4460,
iast (9.144 ms) : 8990, 9298
. : milestone, 9144,
iast_FULL (14.318 ms) : 14027, 14609
. : milestone, 14318,
iast_GLOBAL (10.634 ms) : 10443, 10824
. : milestone, 10634,
profiling (8.627 ms) : 8486, 8768
. : milestone, 8627,
tracing (7.505 ms) : 7399, 7611
. : milestone, 7505,
section candidate
no_agent (4.435 ms) : 4381, 4489
. : milestone, 4435,
iast (9.584 ms) : 9416, 9752
. : milestone, 9584,
iast_FULL (13.917 ms) : 13637, 14196
. : milestone, 13917,
iast_GLOBAL (10.159 ms) : 9966, 10352
. : milestone, 10159,
profiling (9.16 ms) : 9005, 9315
. : milestone, 9160,
tracing (7.92 ms) : 7807, 8032
. : milestone, 7920,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~ac9151dc73, baseline=1.51.0-SNAPSHOT~041214be86
dateFormat X
axisFormat %s
section baseline
no_agent (37.091 ms) : 36793, 37388
. : milestone, 37091,
appsec (47.599 ms) : 47190, 48008
. : milestone, 47599,
code_origins (45.288 ms) : 44897, 45678
. : milestone, 45288,
iast (42.787 ms) : 42415, 43159
. : milestone, 42787,
profiling (48.867 ms) : 48415, 49318
. : milestone, 48867,
tracing (43.355 ms) : 42991, 43720
. : milestone, 43355,
section candidate
no_agent (37.308 ms) : 37013, 37603
. : milestone, 37308,
appsec (47.254 ms) : 46838, 47670
. : milestone, 47254,
code_origins (44.988 ms) : 44590, 45386
. : milestone, 44988,
iast (42.006 ms) : 41645, 42367
. : milestone, 42006,
profiling (49.304 ms) : 48849, 49759
. : milestone, 49304,
tracing (42.909 ms) : 42523, 43296
. : milestone, 42909,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~ac9151dc73, baseline=1.51.0-SNAPSHOT~041214be86
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.395 ms) : 2346, 2444
. : milestone, 2395,
iast (2.191 ms) : 2129, 2253
. : milestone, 2191,
iast_GLOBAL (2.226 ms) : 2163, 2288
. : milestone, 2226,
profiling (2.049 ms) : 1997, 2100
. : milestone, 2049,
tracing (2.0 ms) : 1952, 2048
. : milestone, 2000,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.392 ms) : 2343, 2441
. : milestone, 2392,
iast (2.182 ms) : 2120, 2244
. : milestone, 2182,
iast_GLOBAL (2.226 ms) : 2164, 2289
. : milestone, 2226,
profiling (2.06 ms) : 2009, 2111
. : milestone, 2060,
tracing (2.012 ms) : 1964, 2061
. : milestone, 2012,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~ac9151dc73, baseline=1.51.0-SNAPSHOT~041214be86
dateFormat X
axisFormat %s
section baseline
no_agent (14.805 s) : 14805000, 14805000
. : milestone, 14805000,
appsec (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
iast (18.582 s) : 18582000, 18582000
. : milestone, 18582000,
iast_GLOBAL (17.952 s) : 17952000, 17952000
. : milestone, 17952000,
profiling (15.24 s) : 15240000, 15240000
. : milestone, 15240000,
tracing (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
section candidate
no_agent (15.65 s) : 15650000, 15650000
. : milestone, 15650000,
appsec (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
iast (18.593 s) : 18593000, 18593000
. : milestone, 18593000,
iast_GLOBAL (18.133 s) : 18133000, 18133000
. : milestone, 18133000,
profiling (15.483 s) : 15483000, 15483000
. : milestone, 15483000,
tracing (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
|
bric3
force-pushed
the
bdu/react-properly-on-plugin
branch
from
49a3438 to
3af7215
Compare
bric3
force-pushed
the
bdu/react-properly-on-plugin
branch
from
3af7215 to
68db193
Compare
bric3
commented
Jul 7, 2025
Comment on lines
55
to
+58
| subProj.afterEvaluate { | ||
| if (!plugins.hasPlugin("java")) { | ||
| return | ||
| } |
There was a problem hiding this comment.
Note: this afterEvaluate post pones this configuration at the very end. It might be improved instead with something like with the muzzle plugin applied within.
subProj.plugins.withId("java") { }
However, it doesn't work well at the moment because instrumentation projects may use the muzzle extension before declaring they are using muzzle plugin and before they are applying the java plugin.
In proper Gradle projects project should always prefer the plugins {} block to apply plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Remove workaround for empty instrumentation parent projects.
No differences in final jar entries
Motivation
Reduce configuration duty
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]