-
Notifications
You must be signed in to change notification settings - Fork 305
Alejandro.gonzalez/add http route play in iast #9105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jandro996
wants to merge
3
commits into
master
Choose a base branch
from
alejandro.gonzalez/add-http-route-play-in-iast
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~2a56b37caa, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.004 s) : 0, 1003789
Total [baseline] (8.621 s) : 0, 8621258
Agent [candidate] (1.0 s) : 0, 1000110
Total [candidate] (8.633 s) : 0, 8632694
section iast
Agent [baseline] (1.135 s) : 0, 1134591
Total [baseline] (9.272 s) : 0, 9271549
Agent [candidate] (1.134 s) : 0, 1134032
Total [candidate] (9.239 s) : 0, 9239477
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~2a56b37caa, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.109 ms) : 0, 693109
BytebuddyAgent [candidate] (689.982 ms) : 0, 689982
GlobalTracer [baseline] (243.492 ms) : 0, 243492
GlobalTracer [candidate] (243.433 ms) : 0, 243433
AppSec [baseline] (30.514 ms) : 0, 30514
AppSec [candidate] (30.654 ms) : 0, 30654
Debugger [baseline] (6.125 ms) : 0, 6125
Debugger [candidate] (6.169 ms) : 0, 6169
Remote Config [baseline] (688.111 µs) : 0, 688
Remote Config [candidate] (691.656 µs) : 0, 692
Telemetry [baseline] (8.321 ms) : 0, 8321
Telemetry [candidate] (8.369 ms) : 0, 8369
section iast
BytebuddyAgent [baseline] (808.058 ms) : 0, 808058
BytebuddyAgent [candidate] (808.293 ms) : 0, 808293
GlobalTracer [baseline] (233.494 ms) : 0, 233494
GlobalTracer [candidate] (232.873 ms) : 0, 232873
IAST [baseline] (30.251 ms) : 0, 30251
IAST [candidate] (28.851 ms) : 0, 28851
AppSec [baseline] (26.985 ms) : 0, 26985
AppSec [candidate] (28.889 ms) : 0, 28889
Debugger [baseline] (5.892 ms) : 0, 5892
Debugger [candidate] (5.815 ms) : 0, 5815
Remote Config [baseline] (582.541 µs) : 0, 583
Remote Config [candidate] (586.204 µs) : 0, 586
Telemetry [baseline] (8.045 ms) : 0, 8045
Telemetry [candidate] (8.053 ms) : 0, 8053
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~2a56b37caa, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.073 ms) : 0, 996073
Total [baseline] (10.708 s) : 0, 10707546
Agent [candidate] (995.353 ms) : 0, 995353
Total [candidate] (10.653 s) : 0, 10653498
section appsec
Agent [baseline] (1.184 s) : 0, 1183875
Total [baseline] (10.788 s) : 0, 10788137
Agent [candidate] (1.176 s) : 0, 1175829
Total [candidate] (10.708 s) : 0, 10707789
section iast
Agent [baseline] (1.149 s) : 0, 1148787
Total [baseline] (10.985 s) : 0, 10984643
Agent [candidate] (1.143 s) : 0, 1142826
Total [candidate] (10.838 s) : 0, 10838106
section profiling
Agent [baseline] (1.246 s) : 0, 1245557
Total [baseline] (11.045 s) : 0, 11044733
Agent [candidate] (1.252 s) : 0, 1251765
Total [candidate] (10.956 s) : 0, 10956460
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~2a56b37caa, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.46 ms) : 0, 687460
BytebuddyAgent [candidate] (687.558 ms) : 0, 687558
GlobalTracer [baseline] (242.305 ms) : 0, 242305
GlobalTracer [candidate] (242.037 ms) : 0, 242037
AppSec [baseline] (30.049 ms) : 0, 30049
AppSec [candidate] (30.054 ms) : 0, 30054
Debugger [baseline] (6.0 ms) : 0, 6000
Debugger [candidate] (6.036 ms) : 0, 6036
Remote Config [baseline] (671.746 µs) : 0, 672
Remote Config [candidate] (684.415 µs) : 0, 684
Telemetry [baseline] (8.227 ms) : 0, 8227
Telemetry [candidate] (8.234 ms) : 0, 8234
section appsec
BytebuddyAgent [baseline] (715.894 ms) : 0, 715894
BytebuddyAgent [candidate] (710.671 ms) : 0, 710671
GlobalTracer [baseline] (236.861 ms) : 0, 236861
GlobalTracer [candidate] (235.16 ms) : 0, 235160
IAST [baseline] (23.472 ms) : 0, 23472
IAST [candidate] (23.693 ms) : 0, 23693
AppSec [baseline] (171.661 ms) : 0, 171661
AppSec [candidate] (171.105 ms) : 0, 171105
Debugger [baseline] (5.774 ms) : 0, 5774
Debugger [candidate] (5.783 ms) : 0, 5783
Remote Config [baseline] (604.652 µs) : 0, 605
Remote Config [candidate] (607.002 µs) : 0, 607
Telemetry [baseline] (8.112 ms) : 0, 8112
Telemetry [candidate] (8.062 ms) : 0, 8062
section iast
BytebuddyAgent [baseline] (817.485 ms) : 0, 817485
BytebuddyAgent [candidate] (814.514 ms) : 0, 814514
GlobalTracer [baseline] (236.407 ms) : 0, 236407
GlobalTracer [candidate] (234.775 ms) : 0, 234775
IAST [baseline] (29.168 ms) : 0, 29168
IAST [candidate] (30.78 ms) : 0, 30780
AppSec [baseline] (26.977 ms) : 0, 26977
AppSec [candidate] (26.502 ms) : 0, 26502
Debugger [baseline] (7.676 ms) : 0, 7676
Debugger [candidate] (6.727 ms) : 0, 6727
Remote Config [baseline] (604.279 µs) : 0, 604
Remote Config [candidate] (602.853 µs) : 0, 603
Telemetry [baseline] (8.175 ms) : 0, 8175
Telemetry [candidate] (8.127 ms) : 0, 8127
section profiling
BytebuddyAgent [baseline] (678.645 ms) : 0, 678645
BytebuddyAgent [candidate] (682.39 ms) : 0, 682390
GlobalTracer [baseline] (361.149 ms) : 0, 361149
GlobalTracer [candidate] (362.848 ms) : 0, 362848
AppSec [baseline] (32.447 ms) : 0, 32447
AppSec [candidate] (34.781 ms) : 0, 34781
Debugger [baseline] (11.345 ms) : 0, 11345
Debugger [candidate] (9.137 ms) : 0, 9137
Remote Config [baseline] (666.17 µs) : 0, 666
Remote Config [candidate] (685.23 µs) : 0, 685
Telemetry [baseline] (8.011 ms) : 0, 8011
Telemetry [candidate] (8.791 ms) : 0, 8791
ProfilingAgent [baseline] (103.428 ms) : 0, 103428
ProfilingAgent [candidate] (104.286 ms) : 0, 104286
Profiling [baseline] (103.452 ms) : 0, 103452
Profiling [candidate] (104.31 ms) : 0, 104310
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~2a56b37caa, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (4.464 ms) : 4410, 4519
. : milestone, 4464,
iast (9.093 ms) : 8940, 9246
. : milestone, 9093,
iast_FULL (14.075 ms) : 13798, 14353
. : milestone, 14075,
iast_GLOBAL (10.645 ms) : 10454, 10836
. : milestone, 10645,
profiling (8.901 ms) : 8753, 9049
. : milestone, 8901,
tracing (7.535 ms) : 7429, 7641
. : milestone, 7535,
section candidate
no_agent (4.453 ms) : 4402, 4504
. : milestone, 4453,
iast (9.283 ms) : 9129, 9436
. : milestone, 9283,
iast_FULL (14.101 ms) : 13820, 14382
. : milestone, 14101,
iast_GLOBAL (10.466 ms) : 10283, 10650
. : milestone, 10466,
profiling (9.069 ms) : 8925, 9212
. : milestone, 9069,
tracing (7.524 ms) : 7418, 7629
. : milestone, 7524,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~2a56b37caa, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (37.065 ms) : 36767, 37362
. : milestone, 37065,
appsec (46.735 ms) : 46321, 47149
. : milestone, 46735,
code_origins (45.7 ms) : 45323, 46077
. : milestone, 45700,
iast (45.505 ms) : 45106, 45903
. : milestone, 45505,
profiling (48.564 ms) : 48119, 49009
. : milestone, 48564,
tracing (42.328 ms) : 41954, 42702
. : milestone, 42328,
section candidate
no_agent (36.725 ms) : 36428, 37022
. : milestone, 36725,
appsec (46.098 ms) : 45713, 46482
. : milestone, 46098,
code_origins (44.97 ms) : 44587, 45353
. : milestone, 44970,
iast (43.026 ms) : 42653, 43400
. : milestone, 43026,
profiling (49.608 ms) : 49164, 50052
. : milestone, 49608,
tracing (44.002 ms) : 43635, 44370
. : milestone, 44002,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~2a56b37caa, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.41 ms) : 2360, 2460
. : milestone, 2410,
iast (2.186 ms) : 2124, 2247
. : milestone, 2186,
iast_GLOBAL (2.231 ms) : 2168, 2293
. : milestone, 2231,
profiling (2.051 ms) : 1999, 2103
. : milestone, 2051,
tracing (2.005 ms) : 1957, 2053
. : milestone, 2005,
section candidate
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.399 ms) : 2349, 2448
. : milestone, 2399,
iast (2.181 ms) : 2118, 2243
. : milestone, 2181,
iast_GLOBAL (2.234 ms) : 2172, 2297
. : milestone, 2234,
profiling (2.045 ms) : 1994, 2095
. : milestone, 2045,
tracing (2.01 ms) : 1961, 2059
. : milestone, 2010,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~2a56b37caa, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
appsec (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
iast (18.434 s) : 18434000, 18434000
. : milestone, 18434000,
iast_GLOBAL (17.932 s) : 17932000, 17932000
. : milestone, 17932000,
profiling (15.473 s) : 15473000, 15473000
. : milestone, 15473000,
tracing (14.864 s) : 14864000, 14864000
. : milestone, 14864000,
section candidate
no_agent (15.401 s) : 15401000, 15401000
. : milestone, 15401000,
appsec (15.014 s) : 15014000, 15014000
. : milestone, 15014000,
iast (18.532 s) : 18532000, 18532000
. : milestone, 18532000,
iast_GLOBAL (17.726 s) : 17726000, 17726000
. : milestone, 17726000,
profiling (15.289 s) : 15289000, 15289000
. : milestone, 15289000,
tracing (14.788 s) : 14788000, 14788000
. : milestone, 14788000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm iast
Application Security Management (IAST)
inst: play framework
Play Framework instrumentation
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Store the http.route tag value inside the iast request context in Play framework instrumentation
Motivation
IAST sampling algorithm requires the http.route span tag to be set on the local root span so it can be used for its sampling decision. Since Play does not use the local root span for the http.route we have to store it in the iast request context before the sampling decision is made.
Additional Notes
related with #8991
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]